linux-kernel - Re: [PATCH 4/4] regulator: Add ROHM BD9571MWV-M PMIC regulator driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <5f76efbb-851a-9c69-0b6e-a5bae2ed2e57@gmail.com>
Date:   Tue, 18 Apr 2017 20:39:17 +0200
From:   Marek Vasut <marek.vasut@...il.com>
To:     Mark Brown <broonie@...nel.org>
Cc:     linux-renesas-soc@...r.kernel.org,
        Marek Vasut <marek.vasut+renesas@...il.com>,
        linux-kernel@...r.kernel.org, Liam Girdwood <lgirdwood@...il.com>,
        Geert Uytterhoeven <geert+renesas@...der.be>
Subject: Re: [PATCH 4/4] regulator: Add ROHM BD9571MWV-M PMIC regulator driver

On 04/18/2017 07:57 PM, Mark Brown wrote:
> On Sun, Apr 16, 2017 at 08:08:01PM +0200, Marek Vasut wrote:
> 
> This looks good, a couple of minor things though:
> 
>> +static int bd9571mwv_regulator_is_enabled(struct regulator_dev *reg)
>> +{
>> +	/* Always enabled. */
>> +	return 1;
>> +}
> 
> This should be the default implementation, no need to open code it.

Fixed.

>> +int bd9571mwv_set_voltage_sel_regmap(struct regulator_dev *rdev,
>> +				     unsigned int sel)
>> +{
>> +	return regmap_write_bits(rdev->regmap, BD9571MWV_DVFS_SETVID,
>> +				 rdev->desc->vsel_mask, sel);
>> +}
> 
> regulator_set_voltage_sel_regmap().

I'm using different register for reading and setting the voltage, so
this doesn't work in this case. Plus these two registers have different
format to make it more fun.

-- 
Best regards,
Marek Vasut