linux-kernel - Re: [PATCH 0/4] of: remove *phandle properties from expanded device tree

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <58F6804A.3080206@gmail.com>
Date:   Tue, 18 Apr 2017 14:08:26 -0700
From:   Frank Rowand <frowand.list@...il.com>
To:     Rob Herring <robh+dt@...nel.org>,
        Stephen Boyd <stephen.boyd@...aro.org>
Cc:     devicetree@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 0/4] of: remove *phandle properties from expanded device
 tree

Hi Rob,

Please do not apply this patch series.

The more context I look at, the less this approach seems good.

I hope to have a simpler version completed quickly.

Thanks,

- Frank


On 04/14/17 20:58, Frank Rowand wrote:
> Hi Stephen,
> 
> I left you off the distribution list, sorry...
> 
> On 04/14/17 20:55, frowand.list@...il.com wrote:
>> From: Frank Rowand <frank.rowand@...y.com>
>>
>> Remove "phandle" and "linux,phandle" properties from the internal
>> device tree.  The phandle will still be in the struct device_node
>> phandle field.
>>
>> This is to resolve the issue found by Stephen Boyd [1] when he changed
>> the type of struct property.value from void * to const void *.  As
>> a result of the type change, the overlay code had compile errors
>> where the resolver updates phandle values.
>>
>>   [1] http://lkml.iu.edu/hypermail/linux/kernel/1702.1/04160.html
>>
>> Patch 1 is the phandle related changes.
>>
>> Patches 2 - 4 are minor fixups for issues that became visible
>> while implementing patch 1.
>>
>> Frank Rowand (4):
>>   of: remove *phandle properties from expanded device tree
>>   of: make __of_attach_node() static
>>   of: be consistent in form of file mode
>>   of: detect invalid phandle in overlay
>>
>>  drivers/of/base.c       | 53 +++++++++++++++++++++++++++++++++++++++++++++----
>>  drivers/of/dynamic.c    | 31 ++++++++++++++++-------------
>>  drivers/of/fdt.c        | 40 ++++++++++++++++++++++---------------
>>  drivers/of/of_private.h |  1 -
>>  drivers/of/overlay.c    |  8 +++++---
>>  drivers/of/resolver.c   | 23 +--------------------
>>  include/linux/of.h      |  1 +
>>  7 files changed, 97 insertions(+), 60 deletions(-)