lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Wed, 19 Apr 2017 07:13:27 +0800 From: Leo Yan <leo.yan@...aro.org> To: Mathieu Poirier <mathieu.poirier@...aro.org> Cc: Jonathan Corbet <corbet@....net>, Rob Herring <robh+dt@...nel.org>, Mark Rutland <mark.rutland@....com>, Wei Xu <xuwei5@...ilicon.com>, Catalin Marinas <catalin.marinas@....com>, Will Deacon <will.deacon@....com>, Andy Gross <andy.gross@...aro.org>, David Brown <david.brown@...aro.org>, Suzuki K Poulose <suzuki.poulose@....com>, Stephen Boyd <sboyd@...eaurora.org>, linux-doc@...r.kernel.org, linux-kernel@...r.kernel.org, devicetree@...r.kernel.org, linux-arm-kernel@...ts.infradead.org, linux-arm-msm@...r.kernel.org, linux-soc@...r.kernel.org, Mike Leach <mike.leach@...aro.org>, Sudeep Holla <sudeep.holla@....com> Subject: Re: [PATCH v6 5/8] coresight: use const for device_node structures Hi Mathieu, On Tue, Apr 18, 2017 at 09:24:47AM -0600, Mathieu Poirier wrote: > On Thu, Apr 06, 2017 at 09:30:58PM +0800, Leo Yan wrote: > > Almost low level functions from open firmware have used const to > > qualify device_node structures, so add const for device_node > > parameters in of_coresight related functions. > > > > Reviewed-by: Stephen Boyd <sboyd@...eaurora.org> > > Signed-off-by: Leo Yan <leo.yan@...aro.org> > > I agree with these changes but the patch needs to be split up - please see > below. > > > --- > > drivers/hwtracing/coresight/of_coresight.c | 6 +++--- > > include/linux/coresight.h | 8 ++++---- > > 2 files changed, 7 insertions(+), 7 deletions(-) > > > > diff --git a/drivers/hwtracing/coresight/of_coresight.c b/drivers/hwtracing/coresight/of_coresight.c > > index 78d2399..46eec0f 100644 > > --- a/drivers/hwtracing/coresight/of_coresight.c > > +++ b/drivers/hwtracing/coresight/of_coresight.c > > @@ -52,7 +52,7 @@ of_coresight_get_endpoint_device(struct device_node *endpoint) > > endpoint, of_dev_node_match); > > } > > > > -static void of_coresight_get_ports(struct device_node *node, > > +static void of_coresight_get_ports(const struct device_node *node, > > int *nr_inport, int *nr_outport) > > Move this to a patch by itself as it is not related to this driver. > > > { > > struct device_node *ep = NULL; > > @@ -101,7 +101,7 @@ static int of_coresight_alloc_memory(struct device *dev, > > return 0; > > } > > > > -int of_coresight_get_cpu(struct device_node *node) > > +int of_coresight_get_cpu(const struct device_node *node) > > Move this to the previous patch in this set. There is not need to undo what you > just did there. > > > { > > int cpu; > > bool found; > > @@ -128,7 +128,7 @@ int of_coresight_get_cpu(struct device_node *node) > > EXPORT_SYMBOL_GPL(of_coresight_get_cpu); > > > > struct coresight_platform_data *of_get_coresight_platform_data( > > - struct device *dev, struct device_node *node) > > + struct device *dev, const struct device_node *node) > > Same here, move this to a new patch (the same one as of_coresight_get_ports()). Yeah, this is better than my form. Will change. Thanks, Leo Yan
Powered by blists - more mailing lists