linux-kernel - Re: [PATCH] PCI: faraday: use %pap format string for printing resources

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAErSpo4BrrOrGTyzsw+s4mn-RVGpoZbGpPc95MJ3aDF64SBY_w@mail.gmail.com>
Date:   Wed, 19 Apr 2017 13:42:11 -0500
From:   Bjorn Helgaas <bhelgaas@...gle.com>
To:     Arnd Bergmann <arnd@...db.de>
Cc:     Linus Walleij <linus.walleij@...aro.org>,
        "linux-pci@...r.kernel.org" <linux-pci@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] PCI: faraday: use %pap format string for printing resources

On Wed, Apr 19, 2017 at 12:54 PM, Arnd Bergmann <arnd@...db.de> wrote:
> resource_size_t may be either 32-bit or 64-bit wide, so we have to use
> the special %pap format string to avoid warnings like:
>
> drivers/pci/host/pci-ftpci100.c: In function 'faraday_res_to_memcfg':
> drivers/pci/host/pci-ftpci100.c:174:586: error: format '%x' expects argument of type 'unsigned int', but argument 3 has type 'resource_size_t {aka long long unsigned int}' [-Werror=format=]
> drivers/pci/host/pci-ftpci100.c:174:586: error: format '%x' expects argument of type 'unsigned int', but argument 4 has type 'resource_size_t {aka long long unsigned int}' [-Werror=format=]
>
> This relies on resource_size_t and phys_addr_t being the same width,
> as other code already does.
>
> Fixes: 5c18f2b240bd ("PCI: faraday: Add Faraday Technology FTPCI100 PCI Host Bridge driver")
> Signed-off-by: Arnd Bergmann <arnd@...db.de>

Thanks, folded into the initial commit.

> ---
>  drivers/pci/host/pci-ftpci100.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/pci/host/pci-ftpci100.c b/drivers/pci/host/pci-ftpci100.c
> index 4ae5418a1aad..c0f29d1de341 100644
> --- a/drivers/pci/host/pci-ftpci100.c
> +++ b/drivers/pci/host/pci-ftpci100.c
> @@ -171,8 +171,8 @@ static int faraday_res_to_memcfg(resource_size_t mem_base,
>                 pr_warn("truncated PCI memory base\n");
>         /* Translate to bridge side address space */
>         outval |= (mem_base & FARADAY_PCI_MEMBASE_MASK);
> -       pr_debug("Translated pci base @%08x, size %08x to config %08x\n",
> -                mem_base, mem_size, outval);
> +       pr_debug("Translated pci base @%pap, size %pap to config %08x\n",
> +                &mem_base, &mem_size, outval);
>
>         *val = outval;
>         return 0;
> --
> 2.9.0
>