linux-kernel - Re: [PATCH] i2c: designware-baytrail: fix potential null pointer dereference on dev

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20170419190122.qoudvukbgioxoy3l@ninjato>
Date:   Wed, 19 Apr 2017 21:01:22 +0200
From:   Wolfram Sang <wsa@...-dreams.de>
To:     Colin King <colin.king@...onical.com>
Cc:     Jarkko Nikula <jarkko.nikula@...ux.intel.com>,
        Andy Shevchenko <andriy.shevchenko@...ux.intel.com>,
        Mika Westerberg <mika.westerberg@...ux.intel.com>,
        linux-i2c@...r.kernel.org, kernel-janitors@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] i2c: designware-baytrail: fix potential null pointer
 dereference on dev

On Mon, Mar 20, 2017 at 11:51:23AM +0000, Colin King wrote:
> From: Colin Ian King <colin.king@...onical.com>
> 
> The assignment to addr requires a call to get_sem_addr that dereferences
> dev, however, this dereference occurs before a null pointer check on dev.
> Move this assignment after the null check on dev to avoid a potential null
> pointer dereference.
> 
> Detected by CoverityScan, CID#1419700 ("Dereference before null check")
> 
> Fixes: fd476fa22a1f432 ("i2c: designware-baytrail: Add support for cherrytrail")
> Signed-off-by: Colin Ian King <colin.king@...onical.com>

Applied to for-next, thanks!


Download attachment "signature.asc" of type "application/pgp-signature" (834 bytes)