linux-kernel - Re: [PATCH v2 1/2] hp-wmi: Do not shadow error values

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20170419201120.GA17351@fury>
Date:   Wed, 19 Apr 2017 13:11:20 -0700
From:   Darren Hart <dvhart@...radead.org>
To:     Carlo Caione <carlo@...one.org>
Cc:     andy@...radead.org, andy.shevchenko@...il.com,
        platform-driver-x86@...r.kernel.org, linux-kernel@...r.kernel.org,
        linux@...lessm.com, Carlo Caione <carlo@...lessm.com>
Subject: Re: [PATCH v2 1/2] hp-wmi: Do not shadow error values

On Wed, Apr 19, 2017 at 07:41:53PM +0200, Carlo Caione wrote:
> From: Carlo Caione <carlo@...lessm.com>
> 
> All the helper functions (i.e. hp_wmi_dock_state, hp_wmi_tablet_state,
> ...) using hp_wmi_perform_query to perform an HP WMI query shadow the
> returned value in case of error.
> 
> We return -EINVAL only when the HP WMI query returns a positive value
> (the specific error code) to not mix this up with the actual value
> returned by the helper function.

So Andy is correct in that we try to avoid shadowing error codes where possible.
I accepted v1 of this series because it fixed an existing problem in a way
consistent with the existing code.

Since v1 is already in for-next, let's consider the following a subsequent
cleanup. Would you please create a new patch to address the shadowing error code
issues on top of the v1 patch series.

Thanks,
-- 
Darren Hart
VMware Open Source Technology Center