linux-kernel - Re: [PATCH 1/2] usb: dwc2: Remove unnecessary debug prints

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <1492638950.30293.6.camel@perches.com>
Date:   Wed, 19 Apr 2017 14:55:50 -0700
From:   Joe Perches <joe@...ches.com>
To:     Razmik Karapetyan <Razmik.Karapetyan@...opsys.com>,
        John Youn <John.Youn@...opsys.com>,
        Felipe Balbi <balbi@...nel.org>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        linux-usb@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/2] usb: dwc2: Remove unnecessary debug prints

On Wed, 2017-04-19 at 15:16 +0400, Razmik Karapetyan wrote:
> Removed unnecessary debug prints about DMA mode for host side
> from dwc2_gahbcfg_init() function.

Why are these unnecessary?  Are these emitted elsewhere?

and...

> diff --git a/drivers/usb/dwc2/hcd.c b/drivers/usb/dwc2/hcd.c
[]
> @@ -302,22 +302,10 @@ static int dwc2_gahbcfg_init(struct dwc2_hsotg *hsotg)
[]
>  	if (hsotg->params.host_dma)
>  		ahbcfg |= GAHBCFG_DMA_EN;
> +	else
> +		hsotg->params.dma_desc_enable = false;

This change isn't mentioned in the commit message.
Why is is useful?