linux-kernel - Re: [PATCH 2/2] fs: configfs: use hexadecimal values and new line

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-id: <b8847b65-04c0-11a3-04f9-6e3c4c3a189b@samsung.com>
Date:   Wed, 19 Apr 2017 10:45:43 +0200
From:   Krzysztof Opasiak <k.opasiak@...sung.com>
To:     Stefan Agner <stefan@...er.ch>, balbi@...nel.org
Cc:     gregkh@...uxfoundation.org, linux-usb@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH 2/2] fs: configfs: use hexadecimal values and new line



On 04/15/2017 03:35 AM, Stefan Agner wrote:
> Other unsigned properties return hexadecimal values, follow this
> convention when printing b_vendor_code too. Also add newlines to
> the OS Descriptor support related properties, like other sysfs
> files use.
>
> Signed-off-by: Stefan Agner <stefan@...er.ch>
> ---
>  drivers/usb/gadget/configfs.c | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/usb/gadget/configfs.c b/drivers/usb/gadget/configfs.c
> index 863ca4ded1be..a22a892de7b7 100644
> --- a/drivers/usb/gadget/configfs.c
> +++ b/drivers/usb/gadget/configfs.c
> @@ -738,7 +738,7 @@ static inline struct gadget_info *os_desc_item_to_gadget_info(
>
>  static ssize_t os_desc_use_show(struct config_item *item, char *page)
>  {
> -	return sprintf(page, "%d",
> +	return sprintf(page, "%d\n",
>  			os_desc_item_to_gadget_info(item)->use_os_desc);
>  }
>
> @@ -762,7 +762,7 @@ static ssize_t os_desc_use_store(struct config_item *item, const char *page,
>
>  static ssize_t os_desc_b_vendor_code_show(struct config_item *item, char *page)
>  {
> -	return sprintf(page, "%d",
> +	return sprintf(page, "0x%02x\n",
>  			os_desc_item_to_gadget_info(item)->b_vendor_code);
>  }
>
> @@ -904,7 +904,7 @@ static inline struct usb_os_desc_ext_prop
>
>  static ssize_t ext_prop_type_show(struct config_item *item, char *page)
>  {
> -	return sprintf(page, "%d", to_usb_os_desc_ext_prop(item)->type);
> +	return sprintf(page, "%d\n", to_usb_os_desc_ext_prop(item)->type);
>  }
>
>  static ssize_t ext_prop_type_store(struct config_item *item,
>
looks good to me:

Reviewed-by: Krzysztof Opasiak <k.opasiak@...sung.com>
-- 
Krzysztof Opasiak
Samsung R&D Institute Poland
Samsung Electronics