linux-kernel - Re: [PATCH v4 4/5] perf report: Show branch type statistics for stdio mode

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <a3df40fc-576a-7f3f-3eb6-8e8e29fdd3a3@linux.intel.com>
Date:   Wed, 19 Apr 2017 08:41:56 +0800
From:   "Jin, Yao" <yao.jin@...ux.intel.com>
To:     Jiri Olsa <jolsa@...hat.com>
Cc:     acme@...nel.org, jolsa@...nel.org, peterz@...radead.org,
        mingo@...hat.com, alexander.shishkin@...ux.intel.com,
        Linux-kernel@...r.kernel.org, ak@...ux.intel.com,
        kan.liang@...el.com, yao.jin@...el.com,
        linuxppc-dev@...ts.ozlabs.org
Subject: Re: [PATCH v4 4/5] perf report: Show branch type statistics for stdio
 mode



On 4/19/2017 2:53 AM, Jiri Olsa wrote:
> On Wed, Apr 12, 2017 at 06:21:05AM +0800, Jin Yao wrote:
>
> SNIP
>
>> +static int hist_iter__branch_callback(struct hist_entry_iter *iter,
>> +				      struct addr_location *al __maybe_unused,
>> +				      bool single __maybe_unused,
>> +				      void *arg)
>> +{
>> +	struct hist_entry *he = iter->he;
>> +	struct report *rep = arg;
>> +	struct branch_info *bi;
>> +
>> +	if (sort__mode == SORT_MODE__BRANCH) {
> is this check necessary? the hist_iter__branch_callback
> was set based on this check
>
> jirka

Let me double check.

Thanks
Jin Yao