linux-kernel - Re: [RFC 2/4] Deactivate mmap

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20170419135423.r5zykftem6hrusny@hirez.programming.kicks-ass.net>
Date:   Wed, 19 Apr 2017 15:54:23 +0200
From:   Peter Zijlstra <peterz@...radead.org>
To:     Laurent Dufour <ldufour@...ux.vnet.ibm.com>
Cc:     linux-mm@...ck.org, Davidlohr Bueso <dave@...olabs.net>,
        akpm@...ux-foundation.org, Jan Kara <jack@...e.cz>,
        "Kirill A . Shutemov" <kirill@...temov.name>,
        Michal Hocko <mhocko@...nel.org>,
        Mel Gorman <mgorman@...hsingularity.net>,
        haren@...ux.vnet.ibm.com, aneesh.kumar@...ux.vnet.ibm.com,
        khandual@...ux.vnet.ibm.com, Paul.McKenney@...ibm.com,
        linux-kernel@...r.kernel.org
Subject: Re: [RFC 2/4] Deactivate mmap_sem assert

On Wed, Apr 19, 2017 at 03:45:50PM +0200, Laurent Dufour wrote:
> On 19/04/2017 14:30, Peter Zijlstra wrote:
> > On Wed, Apr 19, 2017 at 02:18:25PM +0200, Laurent Dufour wrote:
> >> When mmap_sem will be moved to a range lock, some assertion done in
> >> the code are no more valid, like the one ensuring mmap_sem is held.
> >>
> > 
> > Why are they no longer valid?
> 
> I didn't explain that very well..
> 
> When using a range lock we can't check that the lock is simply held, but
> if the range we are interesting on is locked or not.

I don't think it matters.. That is, in general you cannot assume
anything about the ranges, therefore, for deadlock analysis you have to
assume each range is the full range.

Once you're there, and assume that each range is the full range, this
test is once again trivial.

The fact that not all ranges are the full range, is merely a performance
consideration, but should not be a correctness issue.