lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Wed, 19 Apr 2017 19:53:24 +0300 From: Alexander Kochetkov <al.kochet@...il.com> To: Florian Fainelli <f.fainelli@...il.com> Cc: netdev@...r.kernel.org, linux-kernel@...r.kernel.org, andrew@...n.ch, Roger Quadros <rogerq@...com>, nsekhar@...com, kyle.roeschley@...com Subject: Re: [PATCH] net: phy: fix auto-negotiation stall due to unavailable interrupt > 19 апр. 2017 г., в 19:32, Florian Fainelli <f.fainelli@...il.com> написал(а): > > http://patchwork.ozlabs.org/patch/743773/ > > Roger can you also test Alexander's patch? If MAC use phy_start_aneg() instead of phy_start() my patch will not work as expected. Roger, if patch don’t work for you please check what MAC bring up PHY using phy_start(): http://patchwork.ozlabs.org/patch/752308/ Is it correct to start PHY inside MAC probe using phy_start_aneg()? Or phy_start() must be used? And probably this tags should be added for my patch: Fixes: 3c293f4e08b5 ("net: phy: Trigger state machine on state change and not polling.") Cc: stable <stable@...r.kernel.org> # v4.9+ Because I bisected to commit 529ed1275263 ("net: phy: phy drivers should not set SUPPORTED_[Asym_]Pause») that looks pretty good. Also, there is another issue I found. link_timeout doesn’t work for interrupt driven PHY. It is possible to implement timer to handle this case. Florian, what do you think? Should this be fixed? Alexander.
Powered by blists - more mailing lists