linux-kernel - Re: [PATCH] lightnvm: assume 64-bit lba numbers

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <b6ea0f56-c4cf-fab9-5e67-eb2c292bd9f3@fb.com>
Date:   Wed, 19 Apr 2017 12:08:03 -0600
From:   Jens Axboe <axboe@...com>
To:     Matias Bjørling <matias@...xlabs.com>,
        Arnd Bergmann <arnd@...db.de>, Matias Bjorling <mb@...htnvm.io>
CC:     Javier González <jg@...htnvm.io>,
        <linux-block@...r.kernel.org>, <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] lightnvm: assume 64-bit lba numbers

On 04/19/2017 12:04 PM, Matias Bjørling wrote:
> On 04/19/2017 07:39 PM, Arnd Bergmann wrote:
>> The driver uses both u64 and sector_t to refer to offsets, and assigns between the
>> two. This causes one harmless warning when sector_t is 32-bit:
>>
>> drivers/lightnvm/pblk-rb.c: In function 'pblk_rb_write_entry_gc':
>> include/linux/lightnvm.h:215:20: error: large integer implicitly truncated to unsigned type [-Werror=overflow]
>> drivers/lightnvm/pblk-rb.c:324:22: note: in expansion of macro 'ADDR_EMPTY'
>>
>> As the driver is already doing this inconsistently, changing the type
>> won't make it worse and is an easy way to avoid the warning.
>>
>> Fixes: a4bd217b4326 ("lightnvm: physical block device (pblk) target")
>> Signed-off-by: Arnd Bergmann <arnd@...db.de>
>> ---
>>  drivers/lightnvm/pblk.h | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/lightnvm/pblk.h b/drivers/lightnvm/pblk.h
>> index c82120ce3be5..11ed7d83f572 100644
>> --- a/drivers/lightnvm/pblk.h
>> +++ b/drivers/lightnvm/pblk.h
>> @@ -119,7 +119,7 @@ struct pblk_w_ctx {
>>  	struct bio_list bios;		/* Original bios - used for completion
>>  					 * in REQ_FUA, REQ_FLUSH case
>>  					 */
>> -	sector_t lba;			/* Logic addr. associated with entry */
>> +	u64 lba;			/* Logic addr. associated with entry */
>>  	struct ppa_addr ppa;		/* Physic addr. associated with entry */
>>  	int flags;			/* Write context flags */
>>  };
>>
> 
> Thanks Arnd. Jens, could you pick this up? Thank you

Done, thanks Arnd.

-- 
Jens Axboe