linux-kernel - Re: [PATCH] ASoC: fsl_asrc_dma: use correct direction enum type

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20170420064320.GA7912@Asurada>
Date:   Wed, 19 Apr 2017 23:43:21 -0700
From:   Nicolin Chen <nicoleotsuka@...il.com>
To:     Stefan Agner <stefan@...er.ch>
Cc:     timur@...i.org, Xiubo.Lee@...il.com, fabio.estevam@....com,
        lgirdwood@...il.com, broonie@...nel.org, perex@...ex.cz,
        tiwai@...e.com, alsa-devel@...a-project.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] ASoC: fsl_asrc_dma: use correct direction enum type

On Wed, Apr 19, 2017 at 11:36:07PM -0700, Stefan Agner wrote:
> The direction argument is of type enum dma_transfer_direction, and
> not enum dma_data_direction. The enumeration values are the same
> so this did not had an effect in practise.
> 
> Signed-off-by: Stefan Agner <stefan@...er.ch>

Acked-by: Nicolin Chen <nicoleotsuka@...il.com>

Thanks

> ---
>  sound/soc/fsl/fsl_asrc_dma.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/sound/soc/fsl/fsl_asrc_dma.c b/sound/soc/fsl/fsl_asrc_dma.c
> index dc30d780f874..282d841840b1 100644
> --- a/sound/soc/fsl/fsl_asrc_dma.c
> +++ b/sound/soc/fsl/fsl_asrc_dma.c
> @@ -76,7 +76,7 @@ static int fsl_asrc_dma_prepare_and_submit(struct snd_pcm_substream *substream)
>  			pair->dma_chan[!dir], runtime->dma_addr,
>  			snd_pcm_lib_buffer_bytes(substream),
>  			snd_pcm_lib_period_bytes(substream),
> -			dir == OUT ? DMA_TO_DEVICE : DMA_FROM_DEVICE, flags);
> +			dir == OUT ? DMA_MEM_TO_DEV : DMA_DEV_TO_MEM, flags);
>  	if (!pair->desc[!dir]) {
>  		dev_err(dev, "failed to prepare slave DMA for Front-End\n");
>  		return -ENOMEM;
> -- 
> 2.12.2
>