linux-kernel - Re: [PATCH] fs:orangefs:orangefs-debug.h: Use ARRAY

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Thu, 20 Apr 2017 15:17:54 +0800
From:   kbuild test robot <lkp@...el.com>
To:     Karim Eshapa <karim.eshapa@...il.com>
Cc:     kbuild-all@...org, hubcap@...ibond.com,
        linux-kernel@...r.kernel.org, Karim Eshapa <karim.eshapa@...il.com>
Subject: Re: [PATCH] fs:orangefs:orangefs-debug.h: Use ARRAY_SIZE kernel macro

Hi Karim,

[auto build test WARNING on linus/master]
[also build test WARNING on v4.11-rc7 next-20170419]
[if your patch is applied to the wrong git tree, please drop us a note to help improve the system]

url:    https://github.com/0day-ci/linux/commits/Karim-Eshapa/fs-orangefs-orangefs-debug-h-Use-ARRAY_SIZE-kernel-macro/20170420-105518
reproduce:
        # apt-get install sparse
        make ARCH=x86_64 allmodconfig
        make C=1 CF=-D__CHECK_ENDIAN__


sparse warnings: (new ones prefixed by >>)

   include/linux/compiler.h:264:8: sparse: attribute 'no_sanitize_address': unknown attribute
   fs/orangefs/orangefs-kernel.h:365:9: sparse: undefined identifier 'gossip_debug'
>> fs/orangefs/orangefs-kernel.h:365:21: sparse: not a function <noident>
   fs/orangefs/orangefs-kernel.h:365:22: sparse: undefined identifier 'GOSSIP_DCACHE_DEBUG'
>> fs/orangefs/orangefs-kernel.h:365:21: sparse: not a function <noident>
   In file included from fs/orangefs/orangefs-debug.h:15:0,
                    from fs/orangefs/protocol.h:336,
                    from fs/orangefs/orangefs-utils.c:6:
   fs/orangefs/orangefs-kernel.h: In function 'is_root_handle':
   fs/orangefs/orangefs-kernel.h:365:2: error: implicit declaration of function 'gossip_debug' [-Werror=implicit-function-declaration]
     gossip_debug(GOSSIP_DCACHE_DEBUG,
     ^~~~~~~~~~~~
   fs/orangefs/orangefs-kernel.h:365:15: error: 'GOSSIP_DCACHE_DEBUG' undeclared (first use in this function)
     gossip_debug(GOSSIP_DCACHE_DEBUG,
                  ^~~~~~~~~~~~~~~~~~~
   fs/orangefs/orangefs-kernel.h:365:15: note: each undeclared identifier is reported only once for each function it appears in
   fs/orangefs/orangefs-kernel.h: In function 'match_handle':
   fs/orangefs/orangefs-kernel.h:381:15: error: 'GOSSIP_DCACHE_DEBUG' undeclared (first use in this function)
     gossip_debug(GOSSIP_DCACHE_DEBUG,
                  ^~~~~~~~~~~~~~~~~~~
   cc1: some warnings being treated as errors

vim +365 fs/orangefs/orangefs-kernel.h

f7ab093f fs/orangefs/pvfs2-kernel.h Mike Marshall 2015-07-17  349  {
8bb8aefd fs/orangefs/pvfs2-kernel.h Yi Liu        2015-11-24  350  	struct orangefs_khandle *khandle;
f7ab093f fs/orangefs/pvfs2-kernel.h Mike Marshall 2015-07-17  351  	ino_t ino;
f7ab093f fs/orangefs/pvfs2-kernel.h Mike Marshall 2015-07-17  352  
f7ab093f fs/orangefs/pvfs2-kernel.h Mike Marshall 2015-07-17  353  	khandle = get_khandle_from_ino(inode);
8bb8aefd fs/orangefs/pvfs2-kernel.h Yi Liu        2015-11-24  354  	ino = orangefs_khandle_to_ino(khandle);
f7ab093f fs/orangefs/pvfs2-kernel.h Mike Marshall 2015-07-17  355  	return ino;
f7ab093f fs/orangefs/pvfs2-kernel.h Mike Marshall 2015-07-17  356  }
f7ab093f fs/orangefs/pvfs2-kernel.h Mike Marshall 2015-07-17  357  
f7ab093f fs/orangefs/pvfs2-kernel.h Mike Marshall 2015-07-17  358  static inline ino_t get_parent_ino_from_dentry(struct dentry *dentry)
f7ab093f fs/orangefs/pvfs2-kernel.h Mike Marshall 2015-07-17  359  {
f7ab093f fs/orangefs/pvfs2-kernel.h Mike Marshall 2015-07-17  360  	return get_ino_from_khandle(dentry->d_parent->d_inode);
f7ab093f fs/orangefs/pvfs2-kernel.h Mike Marshall 2015-07-17  361  }
f7ab093f fs/orangefs/pvfs2-kernel.h Mike Marshall 2015-07-17  362  
f7ab093f fs/orangefs/pvfs2-kernel.h Mike Marshall 2015-07-17  363  static inline int is_root_handle(struct inode *inode)
f7ab093f fs/orangefs/pvfs2-kernel.h Mike Marshall 2015-07-17  364  {
f7ab093f fs/orangefs/pvfs2-kernel.h Mike Marshall 2015-07-17 @365  	gossip_debug(GOSSIP_DCACHE_DEBUG,
f7ab093f fs/orangefs/pvfs2-kernel.h Mike Marshall 2015-07-17  366  		     "%s: root handle: %pU, this handle: %pU:\n",
f7ab093f fs/orangefs/pvfs2-kernel.h Mike Marshall 2015-07-17  367  		     __func__,
8bb8aefd fs/orangefs/pvfs2-kernel.h Yi Liu        2015-11-24  368  		     &ORANGEFS_SB(inode->i_sb)->root_khandle,
f7ab093f fs/orangefs/pvfs2-kernel.h Mike Marshall 2015-07-17  369  		     get_khandle_from_ino(inode));
f7ab093f fs/orangefs/pvfs2-kernel.h Mike Marshall 2015-07-17  370  
8bb8aefd fs/orangefs/pvfs2-kernel.h Yi Liu        2015-11-24  371  	if (ORANGEFS_khandle_cmp(&(ORANGEFS_SB(inode->i_sb)->root_khandle),
f7ab093f fs/orangefs/pvfs2-kernel.h Mike Marshall 2015-07-17  372  			     get_khandle_from_ino(inode)))
f7ab093f fs/orangefs/pvfs2-kernel.h Mike Marshall 2015-07-17  373  		return 0;

:::::: The code at line 365 was first introduced by commit
:::::: f7ab093f74bf638ed98fd1115f3efa17e308bb7f Orangefs: kernel client part 1

:::::: TO: Mike Marshall <hubcap@...ibond.com>
:::::: CC: Mike Marshall <hubcap@...ibond.com>

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation