linux-kernel - Re: [PATCH] pinctrl: make artpec6 explicitly non-modular

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Thu, 20 Apr 2017 09:57:05 +0200
From:   Jesper Nilsson <jesper.nilsson@...s.com>
To:     Paul Gortmaker <paul.gortmaker@...driver.com>
Cc:     linux-kernel@...r.kernel.org, Jesper Nilsson <jespern@...s.com>,
        Lars Persson <larper@...s.com>,
        Niklas Cassel <niklass@...s.com>,
        Linus Walleij <linus.walleij@...aro.org>,
        linux-arm-kernel@...s.com, linux-gpio@...r.kernel.org
Subject: Re: [PATCH] pinctrl: make artpec6 explicitly non-modular

On Wed, Apr 19, 2017 at 03:59:05PM -0400, Paul Gortmaker wrote:
> The Kconfig currently controlling compilation of this code is:
> 
> drivers/pinctrl/Kconfig:config PINCTRL_ARTPEC6
> drivers/pinctrl/Kconfig:        bool "Axis ARTPEC-6 pin controller driver"
> 
> ...meaning that it currently is not being built as a module by anyone.
> 
> Lets remove the modular code that is essentially orphaned, so that
> when reading the driver there is no doubt it is builtin-only.
> 
> Also note that MODULE_DEVICE_TABLE is a no-op for non-modular code.
> 
> We also delete the MODULE_LICENSE tag etc. since all that information
> is already contained at the top of the file in the comments.

Agreed, building as module is useless for this
central pin controller.

Acked-by: Jesper Nilsson <jesper.nilsson@...s.com>

> Cc: Lars Persson <lars.persson@...s.com>
> Cc: Niklas Cassel <niklas.cassel@...s.com>
> Cc: Linus Walleij <linus.walleij@...aro.org>
> Cc: linux-arm-kernel@...s.com
> Cc: linux-gpio@...r.kernel.org
> Signed-off-by: Paul Gortmaker <paul.gortmaker@...driver.com>
> ---
>  drivers/pinctrl/pinctrl-artpec6.c | 12 ------------
>  1 file changed, 12 deletions(-)
> 
> diff --git a/drivers/pinctrl/pinctrl-artpec6.c b/drivers/pinctrl/pinctrl-artpec6.c
> index b5a2eff7ae3d..2886e77fbcf0 100644
> --- a/drivers/pinctrl/pinctrl-artpec6.c
> +++ b/drivers/pinctrl/pinctrl-artpec6.c
> @@ -12,7 +12,6 @@
>  #include <linux/err.h>
>  #include <linux/init.h>
>  #include <linux/io.h>
> -#include <linux/module.h>
>  #include <linux/of.h>
>  #include <linux/platform_device.h>
>  #include <linux/pinctrl/pinctrl.h>
> @@ -979,14 +978,3 @@ static int __init artpec6_pmx_init(void)
>  	return platform_driver_register(&artpec6_pmx_driver);
>  }
>  arch_initcall(artpec6_pmx_init);
> -
> -static void __exit artpec6_pmx_exit(void)
> -{
> -	platform_driver_unregister(&artpec6_pmx_driver);
> -}
> -module_exit(artpec6_pmx_exit);
> -
> -MODULE_AUTHOR("Chris Paterson <chris.paterson@...ux.pieboy.co.uk>");
> -MODULE_DESCRIPTION("Axis ARTPEC-6 pin control driver");
> -MODULE_LICENSE("GPL v2");
> -MODULE_DEVICE_TABLE(of, artpec6_pinctrl_match);
> -- 
> 2.11.0

/^JN - Jesper Nilsson
-- 
               Jesper Nilsson -- jesper.nilsson@...s.com