linux-kernel - Re: [PATCH] backlight: pwm_bl: Fix condition to set enable gpio as output

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAMuHMdXXHNUjexZ5X+rF4+vFrWbqBJ_2zeTUHJLJ8fsww5xvkg@mail.gmail.com>
Date:   Thu, 20 Apr 2017 12:16:36 +0200
From:   Geert Uytterhoeven <geert@...ux-m68k.org>
To:     Daniel Thompson <daniel.thompson@...aro.org>
Cc:     Paul Kocialkowski <contact@...lk.fr>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        Thierry Reding <thierry.reding@...il.com>,
        Lee Jones <lee.jones@...aro.org>,
        Jingoo Han <jingoohan1@...il.com>,
        Bartlomiej Zolnierkiewicz <b.zolnierkie@...sung.com>,
        Linux PWM List <linux-pwm@...r.kernel.org>,
        Linux Fbdev development list <linux-fbdev@...r.kernel.org>,
        linux-tegra@...r.kernel.org
Subject: Re: [PATCH] backlight: pwm_bl: Fix condition to set enable gpio as output

Hi Daniel,

On Thu, Apr 20, 2017 at 11:55 AM, Daniel Thompson
<daniel.thompson@...aro.org> wrote:
> On 18/04/17 09:46, Paul Kocialkowski wrote:
>> Le lundi 17 avril 2017 à 21:36 +0200, Geert Uytterhoeven a écrit :
>>> On Mon, Apr 17, 2017 at 5:38 PM, Paul Kocialkowski <contact@...lk.fr>
>>> wrote:
>>>> Le dimanche 16 avril 2017 à 22:55 +0200, Geert Uytterhoeven a écrit :
>>>>> On Sun, Apr 16, 2017 at 12:35 PM, Paul Kocialkowski <contact@...lk.fr>
>>>>> wrote:
>>>>>>
>>>>>> The move to a dedicated pwm_backlight_initial_power_state function in
>>>>>> commit 7613c922315e308a6486d802abed2eb74443dffd modified the condition
>>>>>> to set the enable gpio as output. This breaks specific use cases using
>>>>>> that GPIO, such as tegra124-based nyan Chromebooks where backlight
>>>>>> stopped working.
>>>>>>
>>>>>> This puts the condition back to the way it was before the move.
>>>>>>
>>>>>> Signed-off-by: Paul Kocialkowski <contact@...lk.fr>
>>>>>
>>>>> Does "[PATCH v2] backlight: pwm_bl: Fix GPIO out for unimplemented
>>>>> .get_direction()"
>>>>> (https://lkml.org/lkml/2017/4/4/225) fix your issue?
>>>>
>>>> This definitely solves the issue!
>>>>
>>>> Since this fixes broken backlight (that, in turn, makes systems
>>>> unusable),
>>>> perhaps this should be included in the next rc cycle?
>>>
>>> You mean v4.11 final, as there probably won't be another rc?
>>> Yes!
>>
>> I'm all for it!
>
> Thanks for keeping our attention on this. I sent a PR yesterday (and hope my
> GPG key has attracted enough signatures).

Thank you, this morning I had already noticed it went upstream.

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@...ux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds