linux-kernel - Re: [PATCH] ALSA: firewire-motu: mark trace helpers as __maybe

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Thu, 20 Apr 2017 12:51:15 +0200
From:   Takashi Iwai <tiwai@...e.de>
To:     "Arnd Bergmann" <arnd@...db.de>
Cc:     "Clemens Ladisch" <clemens@...isch.de>,
        "Jaroslav Kysela" <perex@...ex.cz>, <alsa-devel@...a-project.org>,
        "Takashi Sakamoto" <o-takashi@...amocchi.jp>,
        <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] ALSA: firewire-motu: mark trace helpers as __maybe_unused

On Wed, 19 Apr 2017 19:51:29 +0200,
Arnd Bergmann wrote:
> 
> Two functions were introduced for the purpose of tracing but cause warnings
> when tracing is disabled:
> 
> sound/firewire/motu/amdtp-motu.c:284:13: error: 'copy_message' defined but not used [-Werror=unused-function]
>  static void copy_message(u64 *frames, __be32 *buffer, unsigned int data_blocks,
> sound/firewire/motu/amdtp-motu.c:271:13: error: 'copy_sph' defined but not used [-Werror=unused-function]
>  static void copy_sph(u32 *frames, __be32 *buffer, unsigned int data_blocks,
> 
> Marking them as __maybe_unused will do the right thing here.
> 
> Fixes: 17909c1b3058 ("ALSA: firewire-motu: add tracepoints for SPH in IEC 61883-1 fashion")
> Fixes: c6b0b9e65f09 ("ALSA: firewire-motu: add tracepoints for messages for unique protocol")
> Signed-off-by: Arnd Bergmann <arnd@...db.de>

Applied, thanks.


Takashi