linux-kernel - Re: [PATCH 22/29] dt-bindings: Clarify compatible property for rockchip timers

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Thu, 20 Apr 2017 09:12:29 -0500
From:   Rob Herring <robh@...nel.org>
To:     Daniel Lezcano <daniel.lezcano@...aro.org>
Cc:     tglx@...utronix.de, linux-kernel@...r.kernel.org,
        Alexander Kochetkov <al.kochet@...il.com>,
        Mark Rutland <mark.rutland@....com>,
        Heiko Stuebner <heiko@...ech.de>,
        Huang Tao <huangtao@...k-chips.com>,
        Caesar Wang <wxt@...k-chips.com>,
        "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" 
        <devicetree@...r.kernel.org>,
        "moderated list:ARM/Rockchip SoC support" 
        <linux-arm-kernel@...ts.infradead.org>,
        "open list:ARM/Rockchip SoC support" 
        <linux-rockchip@...ts.infradead.org>
Subject: Re: [PATCH 22/29] dt-bindings: Clarify compatible property for
 rockchip timers

On Sun, Apr 16, 2017 at 10:27:12PM +0200, Daniel Lezcano wrote:
> From: Alexander Kochetkov <al.kochet@...il.com>
> 
> Make all properties description in form '"rockchip,<chip>-timer",
> "rockchip,rk3288-timer"' for all chips found in linux kernel.
> 
> Suggested-by: Heiko Stübner <heiko@...ech.de>
> Signed-off-by: Alexander Kochetkov <al.kochet@...il.com>
> Acked-by: Rob Herring <robh@...nel.org>
> Reviewed-by: Heiko Stuebner <heiko@...ech.de>
> Signed-off-by: Daniel Lezcano <daniel.lezcano@...aro.org>
> ---
>  .../devicetree/bindings/timer/rockchip,rk-timer.txt          | 12 +++++++++---
>  1 file changed, 9 insertions(+), 3 deletions(-)
> 
> diff --git a/Documentation/devicetree/bindings/timer/rockchip,rk-timer.txt b/Documentation/devicetree/bindings/timer/rockchip,rk-timer.txt
> index a41b184..16a5f45 100644
> --- a/Documentation/devicetree/bindings/timer/rockchip,rk-timer.txt
> +++ b/Documentation/devicetree/bindings/timer/rockchip,rk-timer.txt
> @@ -1,9 +1,15 @@
>  Rockchip rk timer
>  
>  Required properties:
> -- compatible: shall be one of:
> -  "rockchip,rk3288-timer" - for rk3066, rk3036, rk3188, rk322x, rk3288, rk3368
> -  "rockchip,rk3399-timer" - for rk3399
> +- compatible: should be:

should be one of:

> +  "rockchip,rk3036-timer", "rockchip,rk3288-timer": for Rockchip RK3036
> +  "rockchip,rk3066-timer", "rockchip,rk3288-timer": for Rockchip RK3066
> +  "rockchip,rk3188-timer", "rockchip,rk3288-timer": for Rockchip RK3188
> +  "rockchip,rk3228-timer", "rockchip,rk3288-timer": for Rockchip RK3228
> +  "rockchip,rk3229-timer", "rockchip,rk3288-timer": for Rockchip RK3229
> +  "rockchip,rk3288-timer": for Rockchip RK3288
> +  "rockchip,rk3368-timer", "rockchip,rk3288-timer": for Rockchip RK3368
> +  "rockchip,rk3399-timer": for Rockchip RK3399

I find the "for Rockchip RKxxxx" a bit redundant, but it's fine with or 
without. Otherwise,

Acked-by: Rob Herring <robh@...nel.org>