linux-kernel - Re: [PATCH v8 5/6] i2c: designware: add SLAVE mode functions

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <b523039c-0120-2861-d9a8-4a8288ffe527@synopsys.com>
Date:   Thu, 20 Apr 2017 15:17:08 +0100
From:   Luis Oliveira <Luis.Oliveira@...opsys.com>
To:     Jarkko Nikula <jarkko.nikula@...ux.intel.com>,
        Luis Oliveira <Luis.Oliveira@...opsys.com>,
        <wsa@...-dreams.de>, <robh+dt@...nel.org>, <mark.rutland@....com>,
        <andriy.shevchenko@...ux.intel.com>,
        <mika.westerberg@...ux.intel.com>, <linux-i2c@...r.kernel.org>,
        <devicetree@...r.kernel.org>, <linux-kernel@...r.kernel.org>
CC:     <Ramiro.Oliveira@...opsys.com>, <Joao.Pinto@...opsys.com>,
        <CARLOS.PALMINHA@...opsys.com>
Subject: Re: [PATCH v8 5/6] i2c: designware: add SLAVE mode functions

On 20-Apr-17 13:50, Jarkko Nikula wrote:
> On 04/12/2017 07:47 PM, Luis Oliveira wrote:
>> - Changes in Kconfig to enable I2C_DESIGNWARE_SLAVE support
>> - Slave functions added to core library file
>> - Slave abort sources added to common source file
>> - New driver: i2c-designware-slave added
>> - Changes in the Makefile to compile the I2C_DESIGNWARE_SLAVE module
>>   when supported by the architecture.
>>
>> All the SLAVE flow is added but it is not enabled via platform
>> driver.
>>
>> Signed-off-by: Luis Oliveira <lolivei@...opsys.com>
>> ---
>> v7-v8
>> - no changes
>>
>>  drivers/i2c/busses/Kconfig                 |  14 +-
>>  drivers/i2c/busses/Makefile                |   1 +
>>  drivers/i2c/busses/i2c-designware-common.c |   6 +
>>  drivers/i2c/busses/i2c-designware-core.h   |   2 +
>>  drivers/i2c/busses/i2c-designware-slave.c  | 403 +++++++++++++++++++++++++++++
>>  5 files changed, 425 insertions(+), 1 deletion(-)
>>  create mode 100644 drivers/i2c/busses/i2c-designware-slave.c
>>
>> diff --git a/drivers/i2c/busses/Kconfig b/drivers/i2c/busses/Kconfig
>> index 144cbadc7c72..84efa57f90b3 100644
>> --- a/drivers/i2c/busses/Kconfig
>> +++ b/drivers/i2c/busses/Kconfig
>> @@ -474,11 +474,23 @@ config I2C_DESIGNWARE_PLATFORM
>>      depends on (ACPI && COMMON_CLK) || !ACPI
>>      help
>>        If you say yes to this option, support will be included for the
>> -      Synopsys DesignWare I2C adapter. Only master mode is supported.
>> +      Synopsys DesignWare I2C adapter.
>>
>>        This driver can also be built as a module.  If so, the module
>>        will be called i2c-designware-platform.
>>
>> +config I2C_DESIGNWARE_SLAVE
>> +    bool "Synopsys DesignWare Slave"
>> +    select I2C_SLAVE
>> +    select I2C_SLAVE_EEPROM
> 
> I didn't notice this before - is there reason to select I2C_SLAVE_EEPROM?
> 
Yeah, this is in the wrong place. I need it to test it, but it shouldn't be
here. I will remove it.