linux-kernel - Re: [PATCH][-next] block, bfq: don't dereference bic before null checking it

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20170420141944.GB10057@kernel.dk>
Date:   Thu, 20 Apr 2017 08:19:44 -0600
From:   Jens Axboe <axboe@...nel.dk>
To:     Colin King <colin.king@...onical.com>
Cc:     Paolo Valente <paolo.valente@...aro.org>,
        linux-block@...r.kernel.org, kernel-janitors@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH][-next] block, bfq: don't dereference bic before null
 checking it

On Thu, Apr 20 2017, Colin King wrote:
> From: Colin Ian King <colin.king@...onical.com>
> 
> The call to bfq_check_ioprio_change will dereference bic, however,
> the null check for bic is after this call.  Move the the null
> check on bic to before the call to avoid any potential null
> pointer dereference issues.

Thanks, added.

-- 
Jens Axboe