linux-kernel - Re: [PATCH] iommu: make iommu_bus_notifier return NOTIFY

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20170420144343.GB21305@8bytes.org>
Date:   Thu, 20 Apr 2017 16:43:44 +0200
From:   Joerg Roedel <joro@...tes.org>
To:     "zhichang.yuan" <yuanzhichang@...ilicon.com>
Cc:     iommu@...ts.linux-foundation.org, linuxarm@...wei.com,
        linux-kernel@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
        lorenzo.pieralisi@....com, zhichang.yuan02@...il.com,
        yankejian@...wei.com, huangdaode@...ilicon.com
Subject: Re: [PATCH] iommu: make iommu_bus_notifier return NOTIFY_DONE rather
 than  error code

On Tue, Apr 18, 2017 at 08:51:48PM +0800, zhichang.yuan wrote:
> In iommu_bus_notifier(), when action is BUS_NOTIFY_ADD_DEVICE, it will return
> 'ops->add_device(dev)' directly. But ops->add_device will return ERR_VAL, such
> as -ENODEV. These value will make notifier_call_chain() not to traverse the
> remain nodes in struct notifier_block list.
> 
> This patch revises iommu_bus_notifier() to return NOTIFY_DONE when some errors
> heppened in ops->add_device().
> 
> Signed-off-by: zhichang.yuan <yuanzhichang@...ilicon.com>

Applied, thanks.