linux-kernel - Re: [PATCH] PCI: dwc/host: Mark PCIe/PCI (MSI) cascade ISR as IRQF_NO

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <000201d2b9e7$ca09a7a0$5e1cf6e0$@gmail.com>
Date:   Thu, 20 Apr 2017 11:07:11 -0400
From:   "Jingoo Han" <jingoohan1@...il.com>
To:     "'Jisheng Zhang'" <jszhang@...vell.com>, <bhelgaas@...gle.com>
Cc:     <Joao.Pinto@...opsys.com>, <svarbanov@...sol.com>,
        <keith.busch@...el.com>, <linux-pci@...r.kernel.org>,
        <linux-kernel@...r.kernel.org>, <linux-arm-msm@...r.kernel.org>
Subject: Re: [PATCH] PCI: dwc/host: Mark PCIe/PCI (MSI) cascade ISR as IRQF_NO_THREAD

On Thursday, April 20, 2017 6:27 AM, Jisheng Zhang wrote:
> 
> Similar as commit 8ff0ef996ca0 ("PCI: host: Mark PCIe/PCI (MSI) IRQ
> cascade handlers as IRQF_NO_THREAD"), we should mark PCIe/PCI (MSI)
> IRQ cascade handlers IRQF_NO_THREAD explicitly. I just found this
> issue in pcie-designware-plat driver, then searched the code, I think
> we should fix pcie-qcom and vmd as well.
> 
> Signed-off-by: Jisheng Zhang <jszhang@...vell.com>

For pcie-designware-plat.c,

Acked-by: Jingoo Han <jingoohan1@...il.com>
Thank you.

Best regards,
Jingoo Han

> ---
>  drivers/pci/dwc/pcie-designware-plat.c | 3 ++-
>  drivers/pci/dwc/pcie-qcom.c            | 3 ++-
>  drivers/pci/host/vmd.c                 | 3 ++-
>  3 files changed, 6 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/pci/dwc/pcie-designware-plat.c
> b/drivers/pci/dwc/pcie-designware-plat.c
> index f20d494922ab..0db1dafc82bb 100644
> --- a/drivers/pci/dwc/pcie-designware-plat.c
> +++ b/drivers/pci/dwc/pcie-designware-plat.c
> @@ -67,7 +67,8 @@ static int dw_plat_add_pcie_port(struct pcie_port *pp,
> 
>  		ret = devm_request_irq(dev, pp->msi_irq,
>  					dw_plat_pcie_msi_irq_handler,
> -					IRQF_SHARED, "dw-plat-pcie-msi",
pp);
> +					IRQF_SHARED | IRQF_NO_THREAD,
> +					"dw-plat-pcie-msi", pp);
>  		if (ret) {
>  			dev_err(dev, "failed to request MSI IRQ\n");
>  			return ret;
> diff --git a/drivers/pci/dwc/pcie-qcom.c b/drivers/pci/dwc/pcie-qcom.c
> index 67eb7f5926dd..a5570c58081e 100644
> --- a/drivers/pci/dwc/pcie-qcom.c
> +++ b/drivers/pci/dwc/pcie-qcom.c
> @@ -727,7 +727,8 @@ static int qcom_pcie_probe(struct platform_device
> *pdev)
> 
>  		ret = devm_request_irq(dev, pp->msi_irq,
>  				       qcom_pcie_msi_irq_handler,
> -				       IRQF_SHARED, "qcom-pcie-msi", pp);
> +				       IRQF_SHARED | IRQF_NO_THREAD,
> +				       "qcom-pcie-msi", pp);
>  		if (ret) {
>  			dev_err(dev, "cannot request msi irq\n");
>  			return ret;
> diff --git a/drivers/pci/host/vmd.c b/drivers/pci/host/vmd.c
> index e27ad2a3bd33..784f63beb487 100644
> --- a/drivers/pci/host/vmd.c
> +++ b/drivers/pci/host/vmd.c
> @@ -704,7 +704,8 @@ static int vmd_probe(struct pci_dev *dev, const struct
> pci_device_id *id)
> 
>  		INIT_LIST_HEAD(&vmd->irqs[i].irq_list);
>  		err = devm_request_irq(&dev->dev, pci_irq_vector(dev, i),
> -				       vmd_irq, 0, "vmd", &vmd->irqs[i]);
> +				       vmd_irq, IRQF_NO_THREAD,
> +				       "vmd", &vmd->irqs[i]);
>  		if (err)
>  			return err;
>  	}
> --
> 2.11.0