linux-kernel - Re: [PATCH v6 4/4] net: dsa: LAN9303: add MDIO managed mode support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20170420160607.kf7bdrlmwrle4ghy@rob-hp-laptop>
Date:   Thu, 20 Apr 2017 11:06:07 -0500
From:   Rob Herring <robh@...nel.org>
To:     Juergen Borleis <jbe@...gutronix.de>
Cc:     netdev@...r.kernel.org, linux-kernel@...r.kernel.org,
        f.fainelli@...il.com, kernel@...gutronix.de, andrew@...n.ch,
        vivien.didelot@...oirfairelinux.com, davem@...emloft.net,
        devicetree@...r.kernel.org, mark.rutland@....com, sr@...x.de
Subject: Re: [PATCH v6 4/4] net: dsa: LAN9303: add MDIO managed mode support

On Tue, Apr 18, 2017 at 10:48:27AM +0200, Juergen Borleis wrote:
> When the LAN9303 device is in MDIO manged mode, all register accesses must
> be done via MDIO.
> 
> Please note: this code is compile time tested only due to the absence of such
> configured hardware. It is based on a patch from Stefan Roese from 2014.
> 
> Signed-off-by: Juergen Borleis <jbe@...gutronix.de>
> CC: devicetree@...r.kernel.org
> CC: robh+dt@...nel.org
> CC: mark.rutland@....com
> CC: sr@...x.de
> ---
>  .../devicetree/bindings/net/dsa/lan9303.txt        |  45 ++++++-

I'd prefer to see the full binding in one separate patch.

Otherwise, looks fine to me.

Acked-by: Rob Herring <robh@...nel.org>

>  drivers/net/dsa/Kconfig                            |   8 ++
>  drivers/net/dsa/Makefile                           |   1 +
>  drivers/net/dsa/lan9303_mdio.c                     | 148 +++++++++++++++++++++
>  4 files changed, 201 insertions(+), 1 deletion(-)
>  create mode 100644 drivers/net/dsa/lan9303_mdio.c