linux-kernel - Re: [PATCH v4 1/1] pwm: pca9685: fix gpio-only operation.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <1492704791.24567.104.camel@linux.intel.com>
Date:   Thu, 20 Apr 2017 19:13:11 +0300
From:   Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
To:     Sven Van Asbroeck <thesven73@...il.com>,
        Andy Shevchenko <andy.shevchenko@...il.com>
Cc:     Thierry Reding <thierry.reding@...il.com>,
        "Rafael J. Wysocki" <rjw@...ysocki.net>, linux-pwm@...r.kernel.org,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        Mika Westerberg <mika.westerberg@...ux.intel.com>,
        Sven Van Asbroeck <TheSven73@...glemail.com>
Subject: Re: [PATCH v4 1/1] pwm: pca9685: fix gpio-only operation.

On Thu, 2017-04-20 at 11:50 -0400, Sven Van Asbroeck wrote:
> > Thus, I would suggest: int sleep -> bool enable (or alike).
> > 
> > Would we agree on that?
> 
> I would. Perhaps also:
> set_sleep_mode(int sleep) -> enable_sleep_mode(bool enable) ?

I'm okay with a such (don't forget to change 0/1 in call sites to
false/true as well).

> Let's see what Mika and Thierry think.

I suppose Mika's answer is an acknowledge to the change.

-- 
Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
Intel Finland Oy