lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Thu, 20 Apr 2017 09:29:50 -0700 From: Andrey Smirnov <andrew.smirnov@...il.com> To: linux-mtd@...ts.infradead.org Cc: Andrey Smirnov <andrew.smirnov@...il.com>, cphealy@...il.com, David Woodhouse <dwmw2@...radead.org>, Brian Norris <computersforpeace@...il.com>, Boris Brezillon <boris.brezillon@...e-electrons.com>, Marek Vasut <marek.vasut@...il.com>, Richard Weinberger <richard@....at>, Cyrille Pitchen <cyrille.pitchen@...el.com>, linux-kernel@...r.kernel.org Subject: [PATCH v4 4/6] mtd: dataflash: Get rid of loop counter in jedec_probe() "For" loop in jedec_probe can be simplified to not need counter 'i'. Convert the code and get rid of the variable. Cc: cphealy@...il.com Cc: David Woodhouse <dwmw2@...radead.org> Cc: Brian Norris <computersforpeace@...il.com> Cc: Boris Brezillon <boris.brezillon@...e-electrons.com> Cc: Marek Vasut <marek.vasut@...il.com> Cc: Richard Weinberger <richard@....at> Cc: Cyrille Pitchen <cyrille.pitchen@...el.com> Cc: linux-kernel@...r.kernel.org Reviewed-by: Marek Vasut <marek.vasut@...il.com> Signed-off-by: Andrey Smirnov <andrew.smirnov@...il.com> --- Changes since [v3] - Collected Reviewed-by from Marek Not present in v2, v1 [v3] http://lkml.kernel.org/r/20170419152305.17226-4-andrew.smirnov@gmail.com drivers/mtd/devices/mtd_dataflash.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/mtd/devices/mtd_dataflash.c b/drivers/mtd/devices/mtd_dataflash.c index ccd1e02..2d3e403 100644 --- a/drivers/mtd/devices/mtd_dataflash.c +++ b/drivers/mtd/devices/mtd_dataflash.c @@ -736,7 +736,7 @@ static struct flash_info dataflash_data[] = { static struct flash_info *jedec_probe(struct spi_device *spi) { - int ret, i; + int ret; u8 code = OP_READ_ID; u8 id[3]; u32 jedec; @@ -767,9 +767,9 @@ static struct flash_info *jedec_probe(struct spi_device *spi) jedec = jedec << 8; jedec |= id[2]; - for (i = 0, info = dataflash_data; - i < ARRAY_SIZE(dataflash_data); - i++, info++) { + for (info = dataflash_data; + info < dataflash_data + ARRAY_SIZE(dataflash_data); + info++) { if (info->jedec_id == jedec) { dev_dbg(&spi->dev, "OTP, sector protect%s\n", (info->flags & SUP_POW2PS) ? -- 2.9.3
Powered by blists - more mailing lists