linux-kernel - Re: [PATCH v2 0/2] nvme APST quirk updates, take two

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <2a988a17-eb37-58ca-edd7-a11d4bb61f5a@kernel.dk>
Date:   Thu, 20 Apr 2017 10:38:23 -0600
From:   Jens Axboe <axboe@...nel.dk>
To:     Keith Busch <keith.busch@...el.com>,
        Sagi Grimberg <sagi@...mberg.me>
Cc:     Andy Lutomirski <luto@...nel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        Kai-Heng Feng <kai.heng.feng@...onical.com>,
        linux-nvme@...ts.infradead.org, Christoph Hellwig <hch@....de>
Subject: Re: [PATCH v2 0/2] nvme APST quirk updates, take two

On 04/20/2017 10:30 AM, Jens Axboe wrote:
> On 04/20/2017 10:29 AM, Keith Busch wrote:
>> On Thu, Apr 20, 2017 at 07:15:15PM +0300, Sagi Grimberg wrote:
>>>
>>>>> Hi Jens-
>>>>>
>>>>> These are just the quirk updates, split out.  The patches are
>>>>> unchanged.
>>>>>
>>>>> I think that, even if we want to apply a broader quirk for 4.11, we
>>>>> should still apply these so that we can cleanly revert the broader
>>>>> quirk later.  IOW, let's get the known regressions fixed before we
>>>>> get too excited about the unknown regressions.
>>>>
>>>> This looks good to me, and 4.11 appropriate. I'll expedite this
>>>> through the block tree, if Keith/Sagi/Christoph agrees on this
>>>> being the right approach for 4.11.
>>>
>>> I'm perfectly fine with this going to 4.11
>>
>> All good with me as well.
>>
>> Reviewed-by: Keith Busch <keith.busch@...el.com>
> 
> Great, I have queued it up.

Spoke too soon. Andy, did you compile this?

drivers/nvme/host/core.c: In function ‘nvme_init_identify’:
drivers/nvme/host/core.c:1524:6: error: ‘force_apst’ undeclared (first use in this function)
  if (force_apst && (ctrl->quirks & NVME_QUIRK_NO_DEEPEST_PS)) {
      ^~~~~~~~~~
drivers/nvme/host/core.c:1524:6: note: each undeclared identifier is reported only once for each function it appears in

No, you did not.

-- 
Jens Axboe