linux-kernel - Re: [PATCH 05/28] drm/bridge: fix include notation and remove -Iinclude/drm flag

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Fri, 21 Apr 2017 07:51:08 +0200
From:   Andrzej Hajda <a.hajda@...sung.com>
To:     Masahiro Yamada <yamada.masahiro@...ionext.com>,
        dri-devel@...ts.freedesktop.org, David Airlie <airlied@...ux.ie>,
        Daniel Vetter <daniel.vetter@...el.com>,
        Jani Nikula <jani.nikula@...ux.intel.com>,
        Sean Paul <seanpaul@...omium.org>
Cc:     linux-kernel@...r.kernel.org
Subject: Re: [PATCH 05/28] drm/bridge: fix include notation and remove
 -Iinclude/drm flag

Hi Masahiro,

On 20.04.2017 11:56, Masahiro Yamada wrote:
> Include <drm/*.h> instead of relative path from include/drm, then
> remove the -Iinclude/drm compiler flag.
>
> Signed-off-by: Masahiro Yamada <yamada.masahiro@...ionext.com>
> ---
>
>  drivers/gpu/drm/bridge/Makefile        |  2 --
>  drivers/gpu/drm/bridge/nxp-ptn3460.c   | 10 +++++-----
>  drivers/gpu/drm/bridge/parade-ps8622.c |  8 ++++----
>  3 files changed, 9 insertions(+), 11 deletions(-)
>
> diff --git a/drivers/gpu/drm/bridge/Makefile b/drivers/gpu/drm/bridge/Makefile
> index 3fe2226..defcf1e 100644
> --- a/drivers/gpu/drm/bridge/Makefile
> +++ b/drivers/gpu/drm/bridge/Makefile
> @@ -1,5 +1,3 @@
> -ccflags-y := -Iinclude/drm
> -
>  obj-$(CONFIG_DRM_ANALOGIX_ANX78XX) += analogix-anx78xx.o
>  obj-$(CONFIG_DRM_DUMB_VGA_DAC) += dumb-vga-dac.o
>  obj-$(CONFIG_DRM_LVDS_ENCODER) += lvds-encoder.o
> diff --git a/drivers/gpu/drm/bridge/nxp-ptn3460.c b/drivers/gpu/drm/bridge/nxp-ptn3460.c
> index 3517043..3fc285a 100644
> --- a/drivers/gpu/drm/bridge/nxp-ptn3460.c
> +++ b/drivers/gpu/drm/bridge/nxp-ptn3460.c
> @@ -24,11 +24,11 @@
>  #include <drm/drm_of.h>
>  #include <drm/drm_panel.h>
>  
> -#include "drm_crtc.h"
> -#include "drm_crtc_helper.h"
> -#include "drm_atomic_helper.h"
> -#include "drm_edid.h"
> -#include "drmP.h"
> +#include <drm/drm_crtc.h>
> +#include <drm/drm_crtc_helper.h>
> +#include <drm/drm_atomic_helper.h>
> +#include <drm/drm_edid.h>
> +#include <drm/drmP.h>

Could you merge these includes with the ones above and sort them
alphabetically.

>  
>  #define PTN3460_EDID_ADDR			0x0
>  #define PTN3460_EDID_EMULATION_ADDR		0x84
> diff --git a/drivers/gpu/drm/bridge/parade-ps8622.c b/drivers/gpu/drm/bridge/parade-ps8622.c
> index 1dcec3b..ada2186 100644
> --- a/drivers/gpu/drm/bridge/parade-ps8622.c
> +++ b/drivers/gpu/drm/bridge/parade-ps8622.c
> @@ -28,10 +28,10 @@
>  #include <drm/drm_of.h>
>  #include <drm/drm_panel.h>
>  
> -#include "drmP.h"
> -#include "drm_crtc.h"
> -#include "drm_crtc_helper.h"
> -#include "drm_atomic_helper.h"
> +#include <drm/drmP.h>
> +#include <drm/drm_crtc.h>
> +#include <drm/drm_crtc_helper.h>
> +#include <drm/drm_atomic_helper.h>

Ditto.

After this change you can add my:
Reviewed-by: Andrzej Hajda <a.hajda@...sung.com>

 --
Regards
Andrzej


>  
>  /* Brightness scale on the Parade chip */
>  #define PS8622_MAX_BRIGHTNESS 0xff