linux-kernel - Re: [PATCH 2/2] i2c: xgene-slimpro: Add ACPI support by using PCC mailbox

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20170421063156.GB1434@katana>
Date:   Fri, 21 Apr 2017 08:31:57 +0200
From:   Wolfram Sang <wsa@...-dreams.de>
To:     Hoan Tran <hotran@....com>
Cc:     linux-i2c@...r.kernel.org, lkml <linux-kernel@...r.kernel.org>,
        Loc Ho <lho@....com>, Keyur Chudgar <kchudgar@....com>
Subject: Re: [PATCH 2/2] i2c: xgene-slimpro: Add ACPI support by using PCC
 mailbox


> > I think it doesn't make sense to print a dev_err and return ENODEV which
> > is treated by the driver core as a non-error. It means "not present, but
> > OK". You probably want other error codes here.
> 
> How about -EINVAL for these -ENODEV error codes? Do you have any suggestion?

-EINVAL will do, I would go for -ENOENT, probably. But it doesn't matter
much.


Download attachment "signature.asc" of type "application/pgp-signature" (820 bytes)