Message-ID: <20170421074317.rqk253sblxjaayzz@lukather>
Date:   Fri, 21 Apr 2017 09:43:17 +0200
From:   Maxime Ripard <maxime.ripard@...e-electrons.com>
To:     Quentin Schulz <quentin.schulz@...e-electrons.com>
Cc:     sre@...nel.org, robh+dt@...nel.org, mark.rutland@....com,
        wens@...e.org, linux@...linux.org.uk, linux-pm@...r.kernel.org,
        linux-sunxi@...glegroups.com, icenowy@...c.xyz,
        liam@...workimprov.net, devicetree@...r.kernel.org,
        linux-kernel@...r.kernel.org, linux-arm-kernel@...ts.infradead.org
Subject: Re: [PATCH v6 0/6] add support for AXP20X and AXP22X battery power
 supply driver

On Tue, Apr 18, 2017 at 09:34:15AM +0200, Quentin Schulz wrote:
> This is a series for AXP20X and AXP22X battery power supply without the
> support for changing constant charge current from the DT. The patches for
> supporting the constant charge current from DT are ready and will be sent
> once the battery framework required to make this work has been merged.
> 
> v6:
>   - removed mention to fixed battery in DT-binding documentation,
> 
> Quote from v4 cover letter:
> 
> The X-Powers AXP20X and AXP22X PMICs have multiple ADCs. They expose
> information and data of the various power supplies they support such as
> ACIN, battery and VBUS. For example, they expose the current battery
> voltage, charge or discharge, as well as ACIN and VBUS current voltages
> and currents, internal PMIC temperature and ADC on 2 different GPIOs
> when in the right mode (for the AXP209 only).
> 
> The ACIN power supply driver is added by this patch. The AXP20X and
> AXP22X can both read the status and the "usability" of the power supply
> but only the AXP209 will be able to tell the current current and voltage
> of the power supply by reading ADC channels. It is simply not supported
> by the AXP22X PMICs.
> 
> The battery power supply driver is also added by this patch. The AXP20X
> and AXP22X share most of their behaviour but have slight variations. The
> allowed target voltages for battery charging are not the same, the
> AXP22X PMIC are able to tell if the battery percentage computed by the
> PMIC is trustworthy and they have different formulas for computing max
> current for battery power supply. The driver is able to give the current
> voltage and current of the battery (be it charging or discharging), the
> maximal and minimal voltage and maximal current allowed for the battery,
> whether the battery is present and usable and its capacity. It will get
> the battery current current and voltage by reading the ADC channels. The
> PMIC allows maximal voltages (4.36V for AXP20X and 4.22V and 4.24V for
> AXP22X) that should not be used with Lithium-based batteries and since
> this PMIC is supposed to be used with Lithium-based batteries, they have
> been disabled. The values returned by the ADC driver are multipled by
> 1000 to scale from the mV returned by the ADC to the uV expected by the
> power supply framework.
> 
> This series of patch adds DT bindings for ACIN power supply, ADC and
> battery power supply drivers for AXP20X and AXP22X PMICs and their
> documentation. It also enables the supported power supplies for the
> Nextthing Co. CHIP and Sinlinx SinA33 boards.
> 
> The different drivers are also added to the MFD cells of the AXP20X and
> AXP22X cells and the writeable and volatile regs updated to work with
> the newly added drivers.
> 
> This series of patch is based on a previous upstreaming attempt done by
> Bruno Prémont few months ago. It differs in three points: the ADC
> driver does not tell the battery temperature (TS_IN) as I do not have a
> board to test it with, it does not tell the instantaneous battery power
> as it returns crazy values for me and finally no support for OCV curves
> for the battery.
> 
> You can test these patches from this repo and branch:
> https://github.com/QSchulz/linux/tree/axp2xx_adc_batt_ac_v4
> 
> v4:
>  - added the ability to set maximum constant charge current from sysfs,
>  - added a warning when setting a higher than current maximum constant charge
>  current,
>  - set default to minimum possible value for current and maximum constant charge
>  current when no battery DT is present or invalid battery DT,
>  - fixed a forgotten custom formula to compute maximum constant charge current
>  for AXP22X,
>  - automatically lower the current constant charge current when it is higher
>  than the maximum constant charge current about to be set,
> 
> v3:
>  - Removed DT property for constant charge current in favor of the WIP
>  battery framework as requested by Sebastian Reichel,
>  - Using a simple if condition instead of a switch in the ADC driver,
>  - Fixed error handling in ADC driver's probe,
>  - Fixed missing call to iio_map_array_unregister in the ADC driver's
>  remove,
>  - Removed ADC driver's DT node and documentation,
>  - Merged IIO channel mapping patches into the original ADC driver
>  patch,
>  - Removed `adding V-OFF to writeable reg' patch as it's already in
>  writeable reg range,
> 
> v2:
>  - Some registers' name have been changed to better reflect their
>  purpose,
>  - Make VBUS power supply driver use IIO channels when AXP ADC driver is
>  enabled, but fall back on previous behavior when disabled. This is made
>  to avoid the ADC driver overwritting registers for VBUS power supply
>  ADC when removed,
>  - Removed useless adding of data registers to volatile registers,
>  - Reordered IIO channels, now grouped by same part of the PMIC (e.g.
>  voltage and current of the battery have the same index in different
>  IIO types),
>  - Added structures for specific data instead of matching on IDs,
>  - Switched from DT IIO channels mapping to iio_map structures IIO
>  channels mapping,
> 
> Quentin
> 
> Quentin Schulz (6):
>   dt-bindings: power: supply: add AXP20X/AXP22X battery DT binding
>   power: supply: add battery driver for AXP20X and AXP22X PMICs
>   ARM: dtsi: axp209: add battery power supply subnode
>   ARM: dtsi: axp22x: add battery power supply subnode
>   ARM: dts: sun8i: sina33: enable battery power supply subnode
>   ARM: sun5i: chip: enable battery power supply subnode

Applied the last 4 patches.

Maxime

-- 
Maxime Ripard, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com

Download attachment "signature.asc" of type "application/pgp-signature" (802 bytes)

Powered by blists - more mailing lists