| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Date: Fri, 21 Apr 2017 17:32:06 +0800
From: kernel test robot <fengguang.wu@...el.com>
To: Thomas Gleixner <tglx@...utronix.de>
Cc: LKP <lkp@...org>, linux-crypto@...r.kernel.org,
linux-kernel@...r.kernel.org, wfg@...ux.intel.com
Subject: [cpu/hotplug] d215aab82d: [ INFO: possible circular locking
dependency detected ]
Greetings,
0day kernel testing robot got the below dmesg and the first bad commit is
https://git.kernel.org/pub/scm/linux/kernel/git/tip/tip.git smp/hotplug
commit d215aab82d81974f438bfbc80aa437132f3c37c3
Author: Thomas Gleixner <tglx@...utronix.de>
AuthorDate: Tue Apr 18 19:05:06 2017 +0200
Commit: Thomas Gleixner <tglx@...utronix.de>
CommitDate: Thu Apr 20 13:08:58 2017 +0200
cpu/hotplug: Convert hotplug locking to percpu rwsem
There are no more (known) nested calls to get_online_cpus() so it's
possible to remove the nested call magic and convert the mutex to a
percpu-rwsem, which speeds up get/put_online_cpus() significantly for the
uncontended case.
The contended case (write locked for hotplug operations) is slow anyway, so
the slightly more expensive down_write of the percpu rwsem does not matter.
[ peterz: Add lockdep assertions ]
Signed-off-by: Thomas Gleixner <tglx@...utronix.de>
Cc: Peter Zijlstra <peterz@...radead.org>
Cc: Sebastian Siewior <bigeasy@...utronix.de>
Cc: Steven Rostedt <rostedt@...dmis.org>
Link: http://lkml.kernel.org/r/20170418170554.382344438@linutronix.de
641693094e perf: Avoid cpu_hotplug_lock r-r recursion
d215aab82d cpu/hotplug: Convert hotplug locking to percpu rwsem
d215aab82d cpu/hotplug: Convert hotplug locking to percpu rwsem
65ec919279 Merge branch 'x86/irq'
+----------------------------------------------------+------------+------------+------------+------------+
| | 641693094e | d215aab82d | d215aab82d | 65ec919279 |
+----------------------------------------------------+------------+------------+------------+------------+
| boot_successes | 33 | 1 | 1 | 0 |
| boot_failures | 0 | 12 | 12 | 11 |
| INFO:possible_circular_locking_dependency_detected | 0 | 12 | 12 | 11 |
+----------------------------------------------------+------------+------------+------------+------------+
[child1:349] uid changed! Was: 0, now 35957
[child0:342] child exiting.
Bailing main loop. Exit reason: UID changed.
[ 69.250950]
[ 69.251227] ======================================================
[ 69.252022] [ INFO: possible circular locking dependency detected ]
[ 69.252715] 4.11.0-rc6-00240-gd215aab #1 Not tainted
[ 69.253273] -------------------------------------------------------
[ 69.254061] kworker/1:1/24 is trying to acquire lock:
[ 69.254699] (cpu_hotplug_lock.rw_sem){++++++}, at: [<ffffffff811ee48e>] static_key_slow_dec+0x1e/0x80
[ 69.255872]
[ 69.255872] but task is already holding lock:
[ 69.256651] (perf_sched_mutex){+.+...}, at: [<ffffffff811d6c0a>] perf_sched_delayed+0x1a/0x70
[ 69.258146]
[ 69.258146] which lock already depends on the new lock.
[ 69.258146]
[ 69.259516]
[ 69.259516] the existing dependency chain (in reverse order) is:
[ 69.260566]
[ 69.260566] -> #2 (perf_sched_mutex){+.+...}:
# HH:MM RESULT GOOD BAD GOOD_BUT_DIRTY DIRTY_NOT_BAD
git bisect start 450dd7177bd6ac5e70d22c5375ef482e9436a748 4f7d029b9bf009fbee76bb10c0c4351a1870d2f3 --
git bisect bad 084d34b9fe3fa15fd649e66a7a8bcfc146c2863f # 12:01 B 0 1 12 0 Merge 'tip/smp/hotplug' into devel-catchup-201704210032
git bisect good b3c310c5863b9563bdd08f8778989d99a9c449c8 # 12:26 G 11 0 0 0 Merge 'linux-review/Sjoerd-Simons/RFC-serial-core-Dynamic-minor-support/20170420-210045' into devel-catchup-201704210032
git bisect good e4708292510f96868aeb8daefb259298e33bdbcb # 12:42 G 11 0 1 1 Merge 'linux-review/Leon-Romanovsky/IB-mlx5-Set-correct-SL-in-completion-for-RoCE/20170420-191557' into devel-catchup-201704210032
git bisect good 650306edb95f2ab1fa07685aaec9c0f74ee534b8 # 13:00 G 11 0 0 0 Merge 'pinchartl-media/omapdrm/fences' into devel-catchup-201704210032
git bisect good ab0d337bb7b090f67b1547a70b383f785c0bb9b1 # 13:35 G 10 0 0 0 Merge 'pinchartl-media/omapdrm/cache-flush' into devel-catchup-201704210032
git bisect good 379c171f26e4acafb52a805afc8d2e2bcc30784e # 13:57 G 11 0 0 0 Merge 'tip/x86/boot' into devel-catchup-201704210032
git bisect good 8153f9ac43897f9f4786b30badc134fcc1a4fb11 # 14:28 G 10 0 0 0 ACPI/processor: Replace racy task affinity logic
git bisect good 91e555edde960481085a8a69ac32726a9f6df0c9 # 14:45 G 11 0 0 0 hwtracing/coresight-etm4x: Use cpuhp_setup_state_nocalls_cpuslocked()
git bisect good b4d1673371196dd9aebdd2f61d946165c777b931 # 15:03 G 11 0 0 0 PCI: Use cpu_hotplug_disable() instead of get_online_cpus()
git bisect good 82947f31231157d8ab70fa8961f23fd3887a3327 # 15:37 G 10 0 0 0 jump_label: Pull get_online_cpus() into generic code
git bisect good 641693094ee1568502280f95900f374b2226b51d # 15:51 G 10 0 0 0 perf: Avoid cpu_hotplug_lock r-r recursion
git bisect bad d215aab82d81974f438bfbc80aa437132f3c37c3 # 16:01 B 0 6 17 0 cpu/hotplug: Convert hotplug locking to percpu rwsem
# first bad commit: [d215aab82d81974f438bfbc80aa437132f3c37c3] cpu/hotplug: Convert hotplug locking to percpu rwsem
git bisect good 641693094ee1568502280f95900f374b2226b51d # 16:16 G 30 0 0 0 perf: Avoid cpu_hotplug_lock r-r recursion
# extra tests with CONFIG_DEBUG_INFO_REDUCED
git bisect bad d215aab82d81974f438bfbc80aa437132f3c37c3 # 16:48 B 0 8 19 0 cpu/hotplug: Convert hotplug locking to percpu rwsem
# extra tests on HEAD of linux-devel/devel-catchup-201704210032
git bisect bad 450dd7177bd6ac5e70d22c5375ef482e9436a748 # 16:48 B 0 11 26 1 0day head guard for 'devel-catchup-201704210032'
# extra tests on tree/branch tip/smp/hotplug
git bisect bad d215aab82d81974f438bfbc80aa437132f3c37c3 # 16:50 B 0 12 24 0 cpu/hotplug: Convert hotplug locking to percpu rwsem
# extra tests with first bad commit reverted
git bisect good 202f4dd0635c28aea54fabc282b989b8f3b074f5 # 17:04 G 10 0 0 0 Revert "cpu/hotplug: Convert hotplug locking to percpu rwsem"
# extra tests on tree/branch tip/master
git bisect bad 65ec9192791aafa1daad627da891417e9e948a18 # 17:26 B 0 2 13 0 Merge branch 'x86/irq'
---
0-DAY kernel test infrastructure Open Source Technology Center
https://lists.01.org/pipermail/lkp Intel Corporation
Download attachment "dmesg-quantal-lkp-hsw01-3:20170421160022:x86_64-randconfig-b0-04210030:4.11.0-rc6-00240-gd215aab:1.gz" of type "application/gzip" (18385 bytes)
View attachment "reproduce-quantal-lkp-hsw01-3:20170421160022:x86_64-randconfig-b0-04210030:4.11.0-rc6-00240-gd215aab:1" of type "text/plain" (888 bytes)
View attachment "config-4.11.0-rc6-00240-gd215aab" of type "text/plain" (87730 bytes)
Powered by blists - more mailing lists