lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Fri, 21 Apr 2017 14:21:59 +0200 From: Michal Hocko <mhocko@...nel.org> To: linux-mm@...ck.org Cc: Andrew Morton <akpm@...ux-foundation.org>, Mel Gorman <mgorman@...e.de>, Vlastimil Babka <vbabka@...e.cz>, Andrea Arcangeli <aarcange@...hat.com>, Jerome Glisse <jglisse@...hat.com>, Reza Arbab <arbab@...ux.vnet.ibm.com>, Yasuaki Ishimatsu <yasu.isimatu@...il.com>, qiuxishi@...wei.com, Kani Toshimitsu <toshi.kani@....com>, slaoub@...il.com, Joonsoo Kim <js1304@...il.com>, Andi Kleen <ak@...ux.intel.com>, David Rientjes <rientjes@...gle.com>, Daniel Kiper <daniel.kiper@...cle.com>, Igor Mammedov <imammedo@...hat.com>, Vitaly Kuznetsov <vkuznets@...hat.com>, LKML <linux-kernel@...r.kernel.org>, Michal Hocko <mhocko@...e.com>, Tobias Regnery <tobias.regnery@...il.com> Subject: [PATCH 12/13] mm, memory_hotplug: fix the section mismatch warning From: Michal Hocko <mhocko@...e.com> Tobias has reported following section mismatches introduced by "mm, memory_hotplug: do not associate hotadded memory to zones until online". WARNING: mm/built-in.o(.text+0x5a1c2): Section mismatch in reference from the function move_pfn_range_to_zone() to the function .meminit.text:memmap_init_zone() The function move_pfn_range_to_zone() references the function __meminit memmap_init_zone(). This is often because move_pfn_range_to_zone lacks a __meminit annotation or the annotation of memmap_init_zone is wrong. WARNING: mm/built-in.o(.text+0x5a25b): Section mismatch in reference from the function move_pfn_range_to_zone() to the function .meminit.text:init_currently_empty_zone() The function move_pfn_range_to_zone() references the function __meminit init_currently_empty_zone(). This is often because move_pfn_range_to_zone lacks a __meminit annotation or the annotation of init_currently_empty_zone is wrong. WARNING: vmlinux.o(.text+0x188aa2): Section mismatch in reference from the function move_pfn_range_to_zone() to the function .meminit.text:memmap_init_zone() The function move_pfn_range_to_zone() references the function __meminit memmap_init_zone(). This is often because move_pfn_range_to_zone lacks a __meminit annotation or the annotation of memmap_init_zone is wrong. WARNING: vmlinux.o(.text+0x188b3b): Section mismatch in reference from the function move_pfn_range_to_zone() to the function .meminit.text:init_currently_empty_zone() The function move_pfn_range_to_zone() references the function __meminit init_currently_empty_zone(). This is often because move_pfn_range_to_zone lacks a __meminit annotation or the annotation of init_currently_empty_zone is wrong. Both memmap_init_zone and init_currently_empty_zone are marked __meminit but move_pfn_range_to_zone is used outside of __meminit sections (e.g. devm_memremap_pages) so we have to hide it from the checker by __ref annotation. Reported-by: Tobias Regnery <tobias.regnery@...il.com> Signed-off-by: Michal Hocko <mhocko@...e.com> --- mm/memory_hotplug.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/mm/memory_hotplug.c b/mm/memory_hotplug.c index c5ca2a8571d0..f9e916a85792 100644 --- a/mm/memory_hotplug.c +++ b/mm/memory_hotplug.c @@ -1070,7 +1070,7 @@ static void __meminit resize_pgdat_range(struct pglist_data *pgdat, unsigned lon pgdat->node_spanned_pages = max(start_pfn + nr_pages, old_end_pfn) - pgdat->node_start_pfn; } -void move_pfn_range_to_zone(struct zone *zone, +void __ref move_pfn_range_to_zone(struct zone *zone, unsigned long start_pfn, unsigned long nr_pages) { struct pglist_data *pgdat = zone->zone_pgdat; -- 2.11.0
Powered by blists - more mailing lists