linux-kernel - Re: mtip32xx: add a status field to struct mtip

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20170421143756.GA31311@lst.de>
Date:   Fri, 21 Apr 2017 16:37:57 +0200
From:   Christoph Hellwig <hch@....de>
To:     Jens Axboe <axboe@...nel.dk>
Cc:     Colin Ian King <colin.king@...onical.com>,
        Christoph Hellwig <hch@....de>,
        Johannes Thumshirn <jthumshirn@...e.de>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: mtip32xx: add a status field to struct mtip_cmd

On Fri, Apr 21, 2017 at 08:14:03AM -0600, Jens Axboe wrote:
> From: Jens Axboe <axboe@...com>
> Subject: [PATCH] mtip32xx: fix dereference of stack garbage
> 
> We need to get the command payload from the request before
> we attempt to dereference it.
> 
> Fixes: 4dda4735c581 ("mtip32xx: add a status field to struct mtip_cmd")
> Signed-off-by: Jens Axboe <axboe@...com>

Looks fine:

Reviewed-by: Christoph Hellwig <hch@....de>