linux-kernel - Re: [PATCH net-next] liquidio: remove unnecessary variable assignment

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Fri, 21 Apr 2017 13:26:23 -0400 (EDT)
From:   David Miller <davem@...emloft.net>
To:     arnd@...db.de
Cc:     derek.chickles@...iumnetworks.com,
        satananda.burla@...iumnetworks.com,
        felix.manlunas@...iumnetworks.com,
        raghu.vatsavayi@...iumnetworks.com, prasad.kanneganti@...ium.com,
        netdev@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH net-next] liquidio: remove unnecessary variable
 assignment

From: Arnd Bergmann <arnd@...db.de>
Date: Wed, 19 Apr 2017 19:30:59 +0200

> gcc points out an useless assignment that was added during code refactoring:
> 
> drivers/net/ethernet/cavium/liquidio/lio_ethtool.c: In function 'octnet_intrmod_callback':
> drivers/net/ethernet/cavium/liquidio/lio_ethtool.c:1315:59: error: parameter 'oct_dev' set but not used [-Werror=unused-but-set-parameter]
> 
> This is harmless but can clearly be remove to avoid the warning.
> 
> Fixes: 50c0add534d2 ("liquidio: refactor interrupt moderation code")
> Signed-off-by: Arnd Bergmann <arnd@...db.de>

Applied.