linux-kernel - Re: [PATCH 09/11] bcache: use kmalloc to allocate bio in bch_data

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CACVXFVMa_Qo2eFhSnt+URaubsr2VSnhW=ypsyjEo5e=L2FG7_w@mail.gmail.com>
Date:   Fri, 21 Apr 2017 23:41:18 +0800
From:   Ming Lei <tom.leiming@...il.com>
To:     NeilBrown <neilb@...e.com>
Cc:     Jens Axboe <axboe@...nel.dk>,
        linux-block <linux-block@...r.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        Kent Overstreet <kent.overstreet@...il.com>,
        "open list:BCACHE (BLOCK LAYER CACHE)" <linux-bcache@...r.kernel.org>
Subject: Re: [PATCH 09/11] bcache: use kmalloc to allocate bio in bch_data_verify()

On Thu, Apr 20, 2017 at 1:38 PM, NeilBrown <neilb@...e.com> wrote:
> This function allocates a bio, then a collection
> of pages.  It copes with failure.
>
> It currently uses a mempool() to allocate the bio,
> but alloc_page() to allocate the pages.  These fail
> in different ways, so the usage is inconsistent.
>
> Change the bio_clone() to bio_clone_kmalloc()
> so that no pool is used either for the bio or the pages.
>
> Signed-off-by: NeilBrown <neilb@...e.com>

Reviewed-by : Ming Lei <ming.lei@...hat.com>


Thanks,
Ming Lei