linux-kernel - Re: [PATCH 2/2] n2rng: Combine substrings for two messages in n2rng

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Fri, 21 Apr 2017 11:22:49 -0700
From:   Joe Perches <joe@...ches.com>
To:     Herbert Xu <herbert@...dor.apana.org.au>,
        SF Markus Elfring <elfring@...rs.sourceforge.net>
Cc:     linux-crypto@...r.kernel.org,
        "David S. Miller" <davem@...emloft.net>,
        Matt Mackall <mpm@...enic.com>,
        Shannon Nelson <shannon.nelson@...cle.com>,
        LKML <linux-kernel@...r.kernel.org>,
        kernel-janitors@...r.kernel.org
Subject: Re: [PATCH 2/2] n2rng: Combine substrings for two messages in
 n2rng_probe()

On Fri, 2017-04-21 at 19:36 +0800, Herbert Xu wrote:
> On Wed, Apr 19, 2017 at 11:11:35AM +0200, SF Markus Elfring wrote:
> > From: Markus Elfring <elfring@...rs.sourceforge.net>
> > Date: Wed, 19 Apr 2017 10:50:04 +0200
> > 
> > The script "checkpatch.pl" pointed information out like the following.
> > 
> > WARNING: quoted string split across lines
> > 
> > Thus fix the affected source code places.
> > 
> > Signed-off-by: Markus Elfring <elfring@...rs.sourceforge.net>
> 
> This patch doesn't seem to add any value so I'm not taking it.

Your choice.

The general reason to merge strings is in CodingStyle

    2) Breaking long lines and strings
    []
    never break user-visible strings such as
    printk messages, because that breaks the ability to grep for them.