linux-kernel - Re: [PATCH] lightnvm: propagate pblk

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <96dcf7b9-542f-4daf-7653-07cd54d0f86d@kernel.dk>
Date:   Fri, 21 Apr 2017 12:41:16 -0600
From:   Jens Axboe <axboe@...nel.dk>
To:     Matias Bjørling <mb@...htnvm.io>,
        Javier González <jg@...htnvm.io>,
        Rakesh Pandit <rakesh@...era.com>
Cc:     linux-block@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] lightnvm: propagate pblk_init return to userspace

On 04/21/2017 12:11 PM, Matias Bjørling wrote:
> On 04/21/2017 05:07 PM, Javier González wrote:
>>> On 20 Apr 2017, at 20.23, Rakesh Pandit <rakesh@...era.com> wrote:
>>>
>>> From userspace calling ioctl(NVM_DEV_CREATE) was returning ENOMEM for
>>> invalid arguments even though pblk (pblk_init) was returning correctly
>>> -EINVAL to nvm_create_tgt inside core.  This patch propagates the
>>> correct return value to userspace.
>>>
>>> Because pblk was introduced recently this only needs to go in 4.12.
>>>
>>> Fixes: a4bd217b4326 ("lightnvm: physical block device (pblk) target")
>>> Signed-off-by: Rakesh Pandit <rakesh@...era.com>
>>>
>>
>> Looks good.
>>
>> Reviewed-by: Javier González <javier@...xlabs.com>
>>
>> Javier
>>
> 
> 
> Jens, would you pick this up as well? :)

Done, thanks Rakesh.

-- 
Jens Axboe