linux-kernel - Re: [PATCH v2] net: arc_emac: switch to phy_start()/phy

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20170421.152409.337926359354412729.davem@davemloft.net>
Date:   Fri, 21 Apr 2017 15:24:09 -0400 (EDT)
From:   David Miller <davem@...emloft.net>
To:     al.kochet@...il.com
Cc:     tremyfr@...il.com, peter.chen@....com, weiyongjun1@...wei.com,
        netdev@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2] net: arc_emac: switch to phy_start()/phy_stop()

From: Alexander Kochetkov <al.kochet@...il.com>
Date: Thu, 20 Apr 2017 16:29:34 +0300

> Currently driver use phy_start_aneg() in arc_emac_open() to bring
> up PHY. But phy_start() function is more appropriate for this purposes.
> Besides that it call phy_start_aneg() as part of PHY startup sequence
> it also can correctly bring up PHY from error and suspended states.
> So the patch replace phy_start_aneg() to phy_start().
> 
> Also the patch add call to phy_stop() to arc_emac_stop() to allow
> the PHY device to be fully suspended when the interface is unused.
> 
> Signed-off-by: Alexander Kochetkov <al.kochet@...il.com>

Applied to net-next, thanks.