linux-kernel - Re: [PATCH v2 03/16] fpga: mgr: API change to replace fpga load functions with single function

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CANk1AXS7YHS8AVQY8rbKpdRY=0UZnEf6p4awRVk_ENSfnSRXgg@mail.gmail.com>
Date:   Fri, 21 Apr 2017 15:08:01 -0500
From:   Alan Tull <atull@...nel.org>
To:     Moritz Fischer <moritz.fischer@...us.com>
Cc:     Alan Tull <atull@...nel.org>,
        linux-kernel <linux-kernel@...r.kernel.org>,
        linux-fpga@...r.kernel.org
Subject: Re: [PATCH v2 03/16] fpga: mgr: API change to replace fpga load
 functions with single function

On Thu, Apr 20, 2017 at 9:09 AM, Alan Tull <atull@...nel.org> wrote:

> @@ -382,7 +377,13 @@ static int fpga_region_notify_pre_apply(struct fpga_region *region,
>         if (of_property_read_bool(nd->overlay, "encrypted-fpga-config"))
>                 info->flags |= FPGA_MGR_ENCRYPTED_BITSTREAM;
>
> -       of_property_read_string(nd->overlay, "firmware-name", &firmware_name);
> +       if (!of_property_read_string(nd->overlay, "firmware-name",
> +                                    &firmware_name)) {
> +               info->firmware_name = devm_kstrdup(dev, firmware_name,
> +                                                  GFP_KERNEL);

For those who weren't copied, the kbuild robot has kindly pointed out
that dev is
undeclared in this function.  It's fixed two patches later, but I'll
need to fix it for
bisectibility in v3.  I actually did bisectibility testing but got
tired and lazy near the
end.  I built & functionality tested individually starting at HEAD,
working back to
about HEAD~11, and then started :/ skipping patches.  Ugh.

Alan