linux-kernel - [PATCH] cgroup: define empty cftype structure for !CONFIG

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Date:   Fri, 21 Apr 2017 23:41:43 +0200
From:   Arnd Bergmann <arnd@...db.de>
To:     Jens Axboe <axboe@...com>
Cc:     Paolo Valente <paolo.valente@...aro.org>,
        Arnd Bergmann <arnd@...db.de>, Tejun Heo <tj@...nel.org>,
        Li Zefan <lizefan@...wei.com>,
        Johannes Weiner <hannes@...xchg.org>,
        Daniel Mack <daniel@...que.org>,
        Ingo Molnar <mingo@...nel.org>, cgroups@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: [PATCH] cgroup: define empty cftype structure for !CONFIG_CGROUPS

There is a new forward declaration for two global cftype arrays, but
that fails to build when CONFIG_CGROUPS is disabled:

In file included from /git/arm-soc/block/bfq-iosched.c:105:0:
block/bfq-iosched.h:820:22: error: array type has incomplete element type 'struct cftype'
 extern struct cftype bfq_blkcg_legacy_files[];
 extern struct cftype bfq_blkg_files[];

This adds an empty definition for the type to make it build again.

Fixes: ea25da48086d ("block, bfq: split bfq-iosched.c into multiple source files")
Signed-off-by: Arnd Bergmann <arnd@...db.de>
---
 include/linux/cgroup-defs.h | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/include/linux/cgroup-defs.h b/include/linux/cgroup-defs.h
index 21745946cae1..cb3cc9588622 100644
--- a/include/linux/cgroup-defs.h
+++ b/include/linux/cgroup-defs.h
@@ -556,6 +556,9 @@ static inline void cgroup_threadgroup_change_end(struct task_struct *tsk)
 
 #else	/* CONFIG_CGROUPS */
 
+struct cftype {
+};
+
 #define CGROUP_SUBSYS_COUNT 0
 
 static inline void cgroup_threadgroup_change_begin(struct task_struct *tsk)
-- 
2.9.0