linux-kernel - RE: [PATCH v1 1/1] srcu-cbmc: Use /usr/bin/awk instead of /bin/awk

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <D3EC02A5926B1B45AA54D922FFAA8B367F505DD2@ORSMSX112.amr.corp.intel.com>
Date:   Fri, 21 Apr 2017 21:52:10 +0000
From:   "Kushwaha, Priyalee" <priyalee.kushwaha@...el.com>
To:     Josh Triplett <josh@...htriplett.org>
CC:     "paulmck@...ux.vnet.ibm.com" <paulmck@...ux.vnet.ibm.com>,
        "shuah@...nel.org" <shuah@...nel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "linux-kselftest@...r.kernel.org" <linux-kselftest@...r.kernel.org>
Subject: RE: [PATCH v1 1/1] srcu-cbmc: Use /usr/bin/awk instead of /bin/awk

Tested 9 distros centos, Debian, Fedora, Gentoo, Opensuse, slackware, Ubuntu, poky showed awk at /usr/bin/awk. 

Here is another similar patch which has been approved https://patchwork.kernel.org/patch/9650581/

centos-7:
lrwxrwxrwx 1 root root 4 Mar 15 19:58 /bin/awk -> gawk lrwxrwxrwx 1 root root 4 Mar 15 19:58 /usr/bin/awk -> gawk

Debian-8:
ls: cannot access /bin/awk: No such file or directory lrwxrwxrwx 1 root root 21 Mar 20 23:26 /usr/bin/awk -> /etc/alternatives/awk

Fedora:
lrwxrwxrwx. 1 root root 4 Sep 12  2016 /bin/awk -> gawk lrwxrwxrwx. 1 root root 4 Sep 12  2016 /usr/bin/awk -> gawk

Gentoo:
lrwxrwxrwx 1 root root 15 Jan  1 13:57 /bin/awk -> ../usr/bin/gawk lrwxrwxrwx 1 root root  4 Jan  1 13:57 /usr/bin/awk -> gawk

Opensuse:
lrwxrwxrwx 1 root root 21 Mar 20 11:19 /bin/awk -> /etc/alternatives/awk lrwxrwxrwx 1 root root 29 Mar 20 11:19 /usr/bin/awk -> /etc/alternatives/usr-bin-awk

Slackware:
lrwxrwxrwx 1 root root  4 Mar 10 15:37 /bin/awk -> gawk lrwxrwxrwx 1 root root 13 Mar 10 15:37 /usr/bin/awk -> ../../bin/awk

Ubuntu:
ls: cannot access '/bin/awk': No such file or directory lrwxrwxrwx 1 root root 21 Dec  6  2015 /usr/bin/awk -> /etc/alternatives/awk

Poky:
ls: /bin/awk: No such file or directory
lrwxrwxrwx    1 root     root            19 Apr 20 22:59 /usr/bin/awk

-----Original Message-----
From: Josh Triplett [mailto:josh@...htriplett.org] 
Sent: Friday, April 21, 2017 11:48 AM
To: Kushwaha, Priyalee <priyalee.kushwaha@...el.com>
Cc: paulmck@...ux.vnet.ibm.com; shuah@...nel.org; linux-kernel@...r.kernel.org; linux-kselftest@...r.kernel.org
Subject: Re: [PATCH v1 1/1] srcu-cbmc: Use /usr/bin/awk instead of /bin/awk

On Sat, Apr 22, 2017 at 10:17:11AM -0700, priyalee.kushwaha@...el.com wrote:
> From: Priyalee Kushwaha <priyalee.kushwaha@...el.com>
> 
> Most OS distribution have awk in /usr/bin not in /bin Without this 
> patch, kernel-devsrc fails to build as runtime dependency for 
> srcu-cbmc script /bin/awk is not found.
> 
> Signed-off-by: Kushwaha, Priyalee <priyalee.kushwaha@...el.com>

For anyone that has it in /bin/awk, does it have a compatibility symlink from /usr/bin/awk (or vice versa), or not?  If not, then this would break the build for those folks.

We could just drop the shebang and the executable bit, and run "awk -f modify_srcu.awk" from whatever script invokes this.

>  tools/testing/selftests/rcutorture/formal/srcu-cbmc/modify_srcu.awk | 
> 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git 
> a/tools/testing/selftests/rcutorture/formal/srcu-cbmc/modify_srcu.awk 
> b/tools/testing/selftests/rcutorture/formal/srcu-cbmc/modify_srcu.awk
> index 8ff8904..c9e8bc5 100755
> --- 
> a/tools/testing/selftests/rcutorture/formal/srcu-cbmc/modify_srcu.awk
> +++ b/tools/testing/selftests/rcutorture/formal/srcu-cbmc/modify_srcu.
> +++ awk
> @@ -1,4 +1,4 @@
> -#!/bin/awk -f
> +#!/usr/bin/awk -f
>  
>  # Modify SRCU for formal verification. The first argument should be 
> srcu.h and  # the second should be srcu.c. Outputs modified srcu.h and 
> srcu.c into the
> --
> 2.10.0
>