linux-kernel - [PATCH] ASoC: fix odd_ptr

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <alpine.DEB.2.20.1704220012490.3038@hadrien>
Date:   Sat, 22 Apr 2017 00:14:57 +0200 (CEST)
From:   Julia Lawall <julia.lawall@...6.fr>
To:     Simon Ho <simon.ho@...exant.com>
cc:     Takashi Iwai <tiwai@...e.de>, alsa-devel@...a-project.org,
        Liam Girdwood <lgirdwood@...il.com>,
        Jaroslav Kysela <perex@...ex.cz>,
        Mark Brown <broonie@...nel.org>, alsa-devel@...a-project.org,
        linux-kernel@...r.kernel.org, kbuild-all@...org
Subject: [PATCH] ASoC: fix odd_ptr_err.cocci warnings (fwd)

I don't think the patch is correct, so I haven't bothered signing off on
it.  Probably the & is not correct in the IS_ERR call?

julia

---------- Forwarded message ----------
Date: Sat, 22 Apr 2017 06:09:26 +0800
From: kbuild test robot <fengguang.wu@...el.com>
To: kbuild@...org
Cc: Julia Lawall <julia.lawall@...6.fr>
Subject: [PATCH] ASoC: fix odd_ptr_err.cocci warnings

 PTR_ERR should access the value just tested by IS_ERR

Semantic patch information:
 There can be false positives in the patch case, where it is the call to
 IS_ERR that is wrong.

Generated by: scripts/coccinelle/tests/odd_ptr_err.cocci

CC: Simon Ho <simon.ho@...exant.com>
Signed-off-by: Fengguang Wu <fengguang.wu@...el.com>
---

Please take the patch only if it's a positive warning. Thanks!

 cx2072x.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

--- a/sound/soc/codecs/cx2072x.c
+++ b/sound/soc/codecs/cx2072x.c
@@ -2183,7 +2183,7 @@ static int cx2072x_i2c_probe(struct i2c_
 		&cx2072x_regmap);

 	if (IS_ERR(&cx2072x->regmap)) {
-		ret = PTR_ERR(cx2072x->regmap);
+		ret = PTR_ERR(&cx2072x->regmap);
 		dev_err(&i2c->dev, "Failed to init regmap: %d\n", ret);
 		return ret;
 	}