| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-ID: <58fa8fe6.FNRDcPla1desvwKQ%fengguang.wu@intel.com>
Date: Sat, 22 Apr 2017 07:04:06 +0800
From: kernel test robot <fengguang.wu@...el.com>
To: Sebastian Andrzej Siewior <bigeasy@...utronix.de>
Cc: LKP <lkp@...org>, linux-kernel@...r.kernel.org,
linux-crypto@...r.kernel.org, Thomas Gleixner <tglx@...utronix.de>,
wfg@...ux.intel.com
Subject: [padata] bbd8797975: WARNING: CPU: 0 PID: 1 at kernel/cpu.c:258
put_online_cpus
Greetings,
0day kernel testing robot got the below dmesg and the first bad commit is
https://git.kernel.org/pub/scm/linux/kernel/git/tip/tip.git smp/hotplug
commit bbd8797975ce0191ac72d575f7e34033b5a5f620
Author: Sebastian Andrzej Siewior <bigeasy@...utronix.de>
AuthorDate: Tue Apr 18 19:04:46 2017 +0200
Commit: Thomas Gleixner <tglx@...utronix.de>
CommitDate: Thu Apr 20 13:08:51 2017 +0200
padata: Avoid nested calls to get_online_cpus() in pcrypt_init_padata()
pcrypt_init_padata()
get_online_cpus()
padata_alloc_possible()
padata_alloc()
get_online_cpus()
The nested call to get_online_cpus() works with the current implementation,
but prevents the conversion to a percpu rwsem.
The other caller of padata_alloc_possible() is pcrypt_init_padata() which
calls from a get_online_cpus() protected region as well.
Remove the get_online_cpus() call in padata_alloc() and document the
calling convention.
Signed-off-by: Sebastian Andrzej Siewior <bigeasy@...utronix.de>
Signed-off-by: Thomas Gleixner <tglx@...utronix.de>
Cc: Steffen Klassert <steffen.klassert@...unet.com>
Cc: Peter Zijlstra <peterz@...radead.org>
Cc: Steven Rostedt <rostedt@...dmis.org>
Cc: linux-crypto@...r.kernel.org
Link: http://lkml.kernel.org/r/20170418170552.697398655@linutronix.de
a792e10c4c padata: Make padata_alloc() static
bbd8797975 padata: Avoid nested calls to get_online_cpus() in pcrypt_init_padata()
d215aab82d cpu/hotplug: Convert hotplug locking to percpu rwsem
9c2e936e65 Merge branch 'WIP.x86/fpu'
+-----------------------------------------------------+------------+------------+------------+------------+
| | a792e10c4c | bbd8797975 | d215aab82d | 9c2e936e65 |
+-----------------------------------------------------+------------+------------+------------+------------+
| boot_successes | 33 | 0 | 0 | 0 |
| boot_failures | 0 | 11 | 12 | 11 |
| WARNING:at_kernel/cpu.c:#put_online_cpus | 0 | 11 | | |
| WARNING:at_kernel/locking/lockdep.c:#__lock_release | 0 | 11 | 12 | 11 |
+-----------------------------------------------------+------------+------------+------------+------------+
[ 65.067325] OCFS2 User DLM kernel interface loaded
[ 65.072268] gfs2: GFS2 installed
[ 65.076252] FS-Cache: Netfs 'ceph' registered for caching
[ 65.078480] ceph: loaded (mds proto 32)
[ 65.083736] ------------[ cut here ]------------
[ 65.086552] WARNING: CPU: 0 PID: 1 at kernel/cpu.c:258 put_online_cpus+0x3d/0x8d
[ 65.090328] CPU: 0 PID: 1 Comm: swapper/0 Not tainted 4.11.0-rc6-00220-gbbd8797 #1
[ 65.093572] Hardware name: QEMU Standard PC (i440FX + PIIX, 1996), BIOS 1.9.3-20161025_171302-gandalf 04/01/2014
[ 65.097477] Call Trace:
[ 65.098821] dump_stack+0xc4/0x122
[ 65.100557] __warn+0xd2/0xf0
[ 65.102175] warn_slowpath_null+0x18/0x1a
[ 65.103888] put_online_cpus+0x3d/0x8d
[ 65.105651] ? kobject_uevent+0xb/0xd
[ 65.107458] pcrypt_init_padata+0x133/0x145
[ 65.109255] ? crypto_ccm_module_init+0x7d/0x7d
[ 65.111265] pcrypt_init+0x44/0xab
[ 65.112726] ? crypto_ccm_module_init+0x7d/0x7d
[ 65.114576] do_one_initcall+0x88/0x15f
[ 65.116409] do_basic_setup+0xa2/0xc0
[ 65.118074] ? kernel_init_freeable+0x107/0x107
[ 65.119931] kernel_init_freeable+0x92/0x107
[ 65.121808] ? rest_init+0x138/0x138
[ 65.123539] kernel_init+0x9/0xee
[ 65.125096] ret_from_fork+0x31/0x40
[ 65.126904] ---[ end trace f7501a7dd73074ba ]---
[ 65.129352] ------------[ cut here ]------------
[ 65.129352] ------------[ cut here ]------------
[ 65.131365] WARNING: CPU: 0 PID: 1 at kernel/locking/lockdep.c:3523 __lock_release+0x7d/0x395
[ 65.135060] DEBUG_LOCKS_WARN_ON(depth <= 0)
[ 65.135064] CPU: 0 PID: 1 Comm: swapper/0 Tainted: G W 4.11.0-rc6-00220-gbbd8797 #1
[ 65.140384] Hardware name: QEMU Standard PC (i440FX + PIIX, 1996), BIOS 1.9.3-20161025_171302-gandalf 04/01/2014
[ 65.144075] Call Trace:
[ 65.145479] dump_stack+0xc4/0x122
[ 65.147296] ? vprintk_func+0x43/0x45
[ 65.148828] __warn+0xd2/0xf0
[ 65.150502] ? put_online_cpus+0x73/0x8d
[ 65.152274] warn_slowpath_fmt+0x44/0x46
[ 65.181795] ? put_online_cpus+0x3d/0x8d
[ 65.182749] __lock_release+0x7d/0x395
[ 65.183722] ? printk+0x3c/0x3e
[ 65.184575] lock_release+0x4a/0x75
[ 65.185511] ? put_online_cpus+0x73/0x8d
[ 65.186512] put_online_cpus+0x8b/0x8d
[ 65.187483] ? kobject_uevent+0xb/0xd
[ 65.191258] pcrypt_init_padata+0x133/0x145
[ 65.192893] ? crypto_ccm_module_init+0x7d/0x7d
[ 65.194775] pcrypt_init+0x44/0xab
[ 65.196439] ? crypto_ccm_module_init+0x7d/0x7d
[ 65.198318] do_one_initcall+0x88/0x15f
[ 65.200114] do_basic_setup+0xa2/0xc0
[ 65.201772] ? kernel_init_freeable+0x107/0x107
[ 65.203655] kernel_init_freeable+0x92/0x107
[ 65.205496] ? rest_init+0x138/0x138
[ 65.207383] kernel_init+0x9/0xee
[ 65.208853] ret_from_fork+0x31/0x40
[ 65.210663] ---[ end trace f7501a7dd73074bb ]---
[ 65.212730] ------------[ cut here ]------------
[ 65.212730] ------------[ cut here ]------------
[ 65.214670] WARNING: CPU: 0 PID: 1 at kernel/cpu.c:258 put_online_cpus+0x3d/0x8d
[ 65.218368] CPU: 0 PID: 1 Comm: swapper/0 Tainted: G W 4.11.0-rc6-00220-gbbd8797 #1
[ 65.221974] Hardware name: QEMU Standard PC (i440FX + PIIX, 1996), BIOS 1.9.3-20161025_171302-gandalf 04/01/2014
[ 65.225929] Call Trace:
[ 65.227435] dump_stack+0xc4/0x122
[ 65.228926] __warn+0xd2/0xf0
[ 65.230648] warn_slowpath_null+0x18/0x1a
[ 65.232426] put_online_cpus+0x3d/0x8d
[ 65.234177] ? kobject_uevent+0xb/0xd
[ 65.235861] pcrypt_init_padata+0x133/0x145
[ 65.237688] ? crypto_ccm_module_init+0x7d/0x7d
[ 65.239575] pcrypt_init+0x5b/0xab
[ 65.241313] ? crypto_ccm_module_init+0x7d/0x7d
[ 65.243080] do_one_initcall+0x88/0x15f
[ 65.244777] do_basic_setup+0xa2/0xc0
[ 65.246595] ? kernel_init_freeable+0x107/0x107
[ 65.248488] kernel_init_freeable+0x92/0x107
[ 65.250420] ? rest_init+0x138/0x138
[ 65.252090] kernel_init+0x9/0xee
[ 65.253695] ret_from_fork+0x31/0x40
[ 65.255430] ---[ end trace f7501a7dd73074bc ]---
[ 65.260862] NET: Registered protocol family 38
# HH:MM RESULT GOOD BAD GOOD_BUT_DIRTY DIRTY_NOT_BAD
git bisect start 55c50180fc1ef6a9cf0f2fb07bdf7715b232c4c0 4f7d029b9bf009fbee76bb10c0c4351a1870d2f3 --
git bisect bad 2fb75380f460ee405369eff321c0033f387e38f7 # 12:49 B 0 2 12 0 Merge 'pci/next' into devel-spot-201704210849
git bisect good 76511bda484929968e54a4b54164efa34c642b51 # 13:23 G 11 0 0 0 Merge 'rcu/rcu/next' into devel-spot-201704210849
git bisect bad 8d7a6f8112f795e40015fe86c409cc00bcd11b46 # 13:41 B 0 1 11 0 Merge 'tip/master' into devel-spot-201704210849
git bisect good 6a1914a735e48a5eccb285b496aeb7072a3d52ed # 14:16 G 10 0 0 0 Merge 'saeed/net-rc' into devel-spot-201704210849
git bisect good 5dc83be3c96856d3199184818bcf280a47eb42eb # 03:11 G 11 0 0 0 Merge 'tip/timers/core' into devel-spot-201704210849
git bisect bad 274e37a664e9ed44e7237068bdc177328f75540c # 03:22 B 0 2 12 0 Merge 'tip/smp/hotplug' into devel-spot-201704210849
git bisect bad 9ef0b62e7059e3ea85e2e5c4894bc2cb78b04eed # 03:45 B 0 5 15 0 x86/mtrr: Remove get_online_cpus() from mtrr_save_state()
git bisect good e878ce0f69caa5c37f3183af711291c0c6a38d6a # 04:06 G 11 0 0 0 stop_machine: Provide stop_machine_cpuslocked()
git bisect bad bbd8797975ce0191ac72d575f7e34033b5a5f620 # 04:22 B 0 4 14 0 padata: Avoid nested calls to get_online_cpus() in pcrypt_init_padata()
git bisect good a792e10c4cb42b8508364c7e187caac2409e6166 # 05:01 G 10 0 0 0 padata: Make padata_alloc() static
# first bad commit: [bbd8797975ce0191ac72d575f7e34033b5a5f620] padata: Avoid nested calls to get_online_cpus() in pcrypt_init_padata()
git bisect good a792e10c4cb42b8508364c7e187caac2409e6166 # 05:30 G 30 0 0 0 padata: Make padata_alloc() static
# extra tests with CONFIG_DEBUG_INFO_REDUCED
git bisect bad bbd8797975ce0191ac72d575f7e34033b5a5f620 # 05:50 B 0 4 14 0 padata: Avoid nested calls to get_online_cpus() in pcrypt_init_padata()
# extra tests on HEAD of linux-devel/devel-spot-201704210849
git bisect bad 55c50180fc1ef6a9cf0f2fb07bdf7715b232c4c0 # 05:56 B 0 15 28 0 0day head guard for 'devel-spot-201704210849'
# extra tests on tree/branch tip/smp/hotplug
git bisect bad d215aab82d81974f438bfbc80aa437132f3c37c3 # 06:13 B 0 3 13 0 cpu/hotplug: Convert hotplug locking to percpu rwsem
# extra tests with first bad commit reverted
git bisect good f49e5c863cb890554d92d5389d9ff7dc3c96035b # 06:40 G 11 0 11 11 Revert "padata: Avoid nested calls to get_online_cpus() in pcrypt_init_padata()"
# extra tests on tree/branch tip/master
git bisect bad 9c2e936e655a62ba3ccd0fa640b121f2db036207 # 06:58 B 0 1 11 0 Merge branch 'WIP.x86/fpu'
---
0-DAY kernel test infrastructure Open Source Technology Center
https://lists.01.org/pipermail/lkp Intel Corporation
Download attachment "dmesg-yocto-vp-6:20170422042348:x86_64-randconfig-a0-04211049:4.11.0-rc6-00220-gbbd8797:1.gz" of type "application/gzip" (53483 bytes)
View attachment "reproduce-yocto-vp-6:20170422042348:x86_64-randconfig-a0-04211049:4.11.0-rc6-00220-gbbd8797:1" of type "text/plain" (903 bytes)
View attachment "config-4.11.0-rc6-00220-gbbd8797" of type "text/plain" (130506 bytes)
Powered by blists - more mailing lists