lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Sat, 22 Apr 2017 10:57:46 +0200 From: Matias Bjørling <mb@...htnvm.io> To: Javier González <jg@...htnvm.io> Cc: linux-block@...r.kernel.org, linux-kernel@...r.kernel.org, Javier González <javier@...xlabs.com> Subject: Re: [PATCH 3/5] lightnvm: pblk: fix memory leak on error path On 04/22/2017 01:32 AM, Javier González wrote: > When write recovery fails, Free memory for the recovery structure. > > Fixes: a4bd217b4326 "lightnvm: physical block device (pblk) target" > > Signed-off-by: Javier González <javier@...xlabs.com> > --- > drivers/lightnvm/pblk-write.c | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/drivers/lightnvm/pblk-write.c b/drivers/lightnvm/pblk-write.c > index 74f7413..a896190 100644 > --- a/drivers/lightnvm/pblk-write.c > +++ b/drivers/lightnvm/pblk-write.c > @@ -142,6 +142,7 @@ static void pblk_end_w_fail(struct pblk *pblk, struct nvm_rq *rqd) > /* Logic error */ > if (bit > c_ctx->nr_valid) { > WARN_ONCE(1, "pblk: corrupted write request\n"); > + mempool_free(recovery, pblk->rec_pool); > goto out; > } > > @@ -149,6 +150,7 @@ static void pblk_end_w_fail(struct pblk *pblk, struct nvm_rq *rqd) > entry = pblk_rb_sync_scan_entry(&pblk->rwb, &ppa); > if (!entry) { > pr_err("pblk: could not scan entry on write failure\n"); > + mempool_free(recovery, pblk->rec_pool); > goto out; > } > > @@ -162,6 +164,7 @@ static void pblk_end_w_fail(struct pblk *pblk, struct nvm_rq *rqd) > ret = pblk_recov_setup_rq(pblk, c_ctx, recovery, comp_bits, c_entries); > if (ret) { > pr_err("pblk: could not recover from write failure\n"); > + mempool_free(recovery, pblk->rec_pool); > goto out; > } > > Reviewed-by: Matias Bjørling <matias@...xlabs.com>
Powered by blists - more mailing lists