linux-kernel - Re: [PATCH] staging: fbtft: fix character limit, trailing ; warning, etc.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Sat, 22 Apr 2017 16:36:34 -0700
From:   Joe Perches <joe@...ches.com>
To:     Eric Curtin <ericcurtin17@...il.com>,
        thomas.petazzoni@...e-electrons.com, gregkh@...uxfoundation.org
Cc:     devel@...verdev.osuosl.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] staging: fbtft: fix character limit, trailing ;
 warning, etc.

On Sat, 2017-04-22 at 16:26 +0100, Eric Curtin wrote:
> checkpatch spits out a warning about the 80 character line limit. Split
> the parameters of these functions onto different lines. Put the ; with
> the macro caller instead. Lined up parameters as there was another
> CHECK warning about that.
[]
> diff --git a/drivers/staging/fbtft/fbtft-bus.c b/drivers/staging/fbtft/fbtft-bus.c
[]
> @@ -24,7 +24,14 @@ void func(struct fbtft_par *par, int len, ...)                                \
>  			buf[i] = (type)va_arg(args, unsigned int);            \
>  		}                                                             \
>  		va_end(args);                                                 \
> -		fbtft_par_dbg_hex(DEBUG_WRITE_REGISTER, par, par->info->device, type, buf, len, "%s: ", __func__);   \
> +		fbtft_par_dbg_hex(DEBUG_WRITE_REGISTER,			      \
> +				  par,					      \
> +				  par->info->device,			      \
> +				  type,					      \
> +				  buf,					      \
> +				  len,					      \
> +				  "%s: ",				      \
> +				  __func__);				      \
>  	}                                                                     \

Multiple arguments per line please before 80 columns

		fbtft_par_dbg_hex(DEBUG_WRITE_REGISTER, par,                  \
				  par->info->device, type, buf, len,          \
				  "%s: ", __func__);                          \