linux-kernel - Re: [PATCH 2/8] selftests: lib.mk: define CLEAN macro to allow Makefiles to override clean

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <87zif9ypax.fsf@concordia.ellerman.id.au>
Date:   Sat, 22 Apr 2017 15:38:46 +1000
From:   Michael Ellerman <mpe@...erman.id.au>
To:     Shuah Khan <shuahkh@....samsung.com>, shuah@...nel.org,
        bamvor.zhangjian@...aro.org, benh@...nel.crashing.org,
        paulus@...ba.org, dvhart@...radead.org
Cc:     Shuah Khan <shuahkh@....samsung.com>, viro@...iv.linux.org.uk,
        emilio.lopez@...labora.co.uk, mingo@...nel.org, luto@...nel.org,
        dave.hansen@...ux.intel.com, dsafonov@...tuozzo.com,
        rkrcmar@...hat.com, linux-kselftest@...r.kernel.org,
        linux-kernel@...r.kernel.org, linux-gpio@...r.kernel.org,
        linuxppc-dev@...ts.ozlabs.org
Subject: Re: [PATCH 2/8] selftests: lib.mk: define CLEAN macro to allow Makefiles to override clean

Shuah Khan <shuahkh@....samsung.com> writes:

> Define CLEAN macro to allow Makefiles to override common clean target
> in lib.mk. This will help fix the following failures:
>
> warning: overriding recipe for target 'clean'
> ../lib.mk:55: warning: ignoring old recipe for target 'clean'
>
> Signed-off-by: Shuah Khan <shuahkh@....samsung.com>

Should probably have:

Fixes: 88baa78d1f31 ("selftests: remove duplicated all and clean target")


In hindsight I'm not sure moving the clean target into lib.mk was
the best idea, but anyway it's a bit late to change our mind on that.

This patch is a good solution to fix the warnings.

Acked-by: Michael Ellerman <mpe@...erman.id.au>

cheers