linux-kernel - Re: [PATCH 6/8] selftests: splice: override clean in lib.mk to fix warnings

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <87tw5hyp7z.fsf@concordia.ellerman.id.au>
Date:   Sat, 22 Apr 2017 15:40:32 +1000
From:   Michael Ellerman <mpe@...erman.id.au>
To:     Shuah Khan <shuahkh@....samsung.com>, shuah@...nel.org,
        bamvor.zhangjian@...aro.org, benh@...nel.crashing.org,
        paulus@...ba.org, dvhart@...radead.org
Cc:     Shuah Khan <shuahkh@....samsung.com>, viro@...iv.linux.org.uk,
        emilio.lopez@...labora.co.uk, mingo@...nel.org, luto@...nel.org,
        dave.hansen@...ux.intel.com, dsafonov@...tuozzo.com,
        rkrcmar@...hat.com, linux-kselftest@...r.kernel.org,
        linux-kernel@...r.kernel.org, linux-gpio@...r.kernel.org,
        linuxppc-dev@...ts.ozlabs.org
Subject: Re: [PATCH 6/8] selftests: splice: override clean in lib.mk to fix warnings

Shuah Khan <shuahkh@....samsung.com> writes:

> Add override for lib.mk clean to fix the following warnings from clean
> target run.
>
> Makefile:8: warning: overriding recipe for target 'clean'
> ../lib.mk:55: warning: ignoring old recipe for target 'clean'
>
> Signed-off-by: Shuah Khan <shuahkh@....samsung.com>
> ---
>  tools/testing/selftests/splice/Makefile | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/tools/testing/selftests/splice/Makefile b/tools/testing/selftests/splice/Makefile
> index 559512c..3f967ba 100644
> --- a/tools/testing/selftests/splice/Makefile
> +++ b/tools/testing/selftests/splice/Makefile
> @@ -4,5 +4,6 @@ all: $(TEST_PROGS) $(EXTRA)
>  
>  include ../lib.mk
>  
> -clean:
> +override define CLEAN
>  	rm -fr $(EXTRA)
> +endef

Could just be:

EXTRA_CLEAN := $(EXTRA)

cheers