linux-kernel - [PATCH v2] bus: fsl-mc: dpio: fix alter FQ state command

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20170422064449.25498-1-horia.geanta@nxp.com>
Date:   Sat, 22 Apr 2017 09:44:49 +0300
From:   Horia Geantă <horia.geanta@....com>
To:     <gregkh@...uxfoundation.org>, Roy Pledge <roy.pledge@....com>
CC:     <devel@...verdev.osuosl.org>, <linux-kernel@...r.kernel.org>,
        Haiying Wang <haiying.wang@....com>,
        Ioana Radulescu <ruxandra.radulescu@....com>,
        Stuart Yoder <stuyoder@...il.com>
Subject: [PATCH v2] bus: fsl-mc: dpio: fix alter FQ state command

When checking the response verb, the valid bit should be masked out,
since its value flips depending on what Response Register
(RR0 /RR1) it's been read from.

Fixes: 321eecb06bfb ("bus: fsl-mc: dpio: add QBMan portal APIs for DPAA2")
Signed-off-by: Horia Geantă <horia.geanta@....com>
---
v2: use QBMAN_RESULT_MASK instead of hard-coded mask

 drivers/staging/fsl-mc/bus/dpio/qbman-portal.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/staging/fsl-mc/bus/dpio/qbman-portal.c b/drivers/staging/fsl-mc/bus/dpio/qbman-portal.c
index 2a3ea29d9b43..7988612aaecf 100644
--- a/drivers/staging/fsl-mc/bus/dpio/qbman-portal.c
+++ b/drivers/staging/fsl-mc/bus/dpio/qbman-portal.c
@@ -963,7 +963,7 @@ int qbman_swp_alt_fq_state(struct qbman_swp *s, u32 fqid,
 	}
 
 	/* Decode the outcome */
-	WARN_ON(r->verb != alt_fq_verb);
+	WARN_ON((r->verb & QBMAN_RESULT_MASK) != alt_fq_verb);
 
 	/* Determine success or failure */
 	if (unlikely(r->rslt != QBMAN_MC_RSLT_OK)) {
-- 
2.12.0.264.gd6db3f216544