linux-kernel - Re: [PATCH v1 1/8] lib/uuid: Introduce uuid_{be|le}_cmp

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1492975128.3570.2.camel@intel.com>
Date:   Sun, 23 Apr 2017 20:20:33 +0000
From:   "Winkler, Tomas" <tomas.winkler@...el.com>
To:     "andy.shevchenko@...il.com" <andy.shevchenko@...il.com>
CC:     "kvm@...r.kernel.org" <kvm@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "alex.williamson@...hat.com" <alex.williamson@...hat.com>,
        "Koul, Vinod" <vinod.koul@...el.com>,
        "devel@...uxdriverproject.org" <devel@...uxdriverproject.org>,
        "kwankhede@...dia.com" <kwankhede@...dia.com>,
        "kys@...rosoft.com" <kys@...rosoft.com>,
        "ard.biesheuvel@...aro.org" <ard.biesheuvel@...aro.org>,
        "matt@...eblueprint.co.uk" <matt@...eblueprint.co.uk>,
        "broonie@...nel.org" <broonie@...nel.org>,
        "akpm@...ux-foundation.org" <akpm@...ux-foundation.org>,
        "rjw@...ysocki.net" <rjw@...ysocki.net>,
        "sthemmin@...rosoft.com" <sthemmin@...rosoft.com>,
        "srinivas.pandruvada@...ux.intel.com" 
        <srinivas.pandruvada@...ux.intel.com>,
        "mika.westerberg@...ux.intel.com" <mika.westerberg@...ux.intel.com>,
        "linux-efi@...r.kernel.org" <linux-efi@...r.kernel.org>,
        "lgirdwood@...il.com" <lgirdwood@...il.com>,
        "linux-input@...r.kernel.org" <linux-input@...r.kernel.org>,
        "benjamin.tissoires@...hat.com" <benjamin.tissoires@...hat.com>,
        "arnd@...db.de" <arnd@...db.de>,
        "andriy.shevchenko@...ux.intel.com" 
        <andriy.shevchenko@...ux.intel.com>,
        "alsa-devel@...a-project.org" <alsa-devel@...a-project.org>,
        "haiyangz@...rosoft.com" <haiyangz@...rosoft.com>,
        "linux-acpi@...r.kernel.org" <linux-acpi@...r.kernel.org>
Subject: Re: [PATCH v1 1/8] lib/uuid: Introduce uuid_{be|le}_cmp_p{p}()
 helpers

On Sun, 2017-04-23 at 15:42 +0300, Andy Shevchenko wrote:
> On Sun, Apr 23, 2017 at 1:29 PM, Winkler, Tomas <tomas.winkler@...el.
> com> wrote:
> > > New helpers take pointers to uuid_{be|le} as parameters.
> > > 
> > > When using them on a raw data we don't need to do an ugly
> > > dereference and,
> > > in some cases, a type casting.
> > I think this going overboard, the _pp types  are just enough.
> 
> I looked at existing users and there are cases like
> #define XXX_UUID UUID_...(a, b, c, ...)
> 
> uuid_.*_cmp(value, XXX_UUID)
> 
> For _pp variant if would be _cmp_pp(value, &XXX_UUID) which is
> slightly worse than for _p variant.


Maybe it's worth to actually replace the defines with variables than to
create an interface with all the permutations.

Tomas