linux-kernel - [PATCH] staging: rtl8192u: Fix sparse warning

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Date:   Sun, 23 Apr 2017 17:51:17 -0300
From:   Marcos Paulo de Souza <marcos.souza.org@...il.com>
To:     unlisted-recipients:; (no To-header on input)
Cc:     Marcos Paulo de Souza <marcos.souza.org@...il.com>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Bhumika Goyal <bhumirks@...il.com>,
        Arnd Bergmann <arnd@...db.de>,
        simran singhal <singhalsimran0@...il.com>,
        Tobias Klauser <tklauser@...tanz.ch>,
        Elise Lennion <elise.lennion@...il.com>,
        devel@...verdev.osuosl.org, linux-kernel@...r.kernel.org
Subject: [PATCH] staging: rtl8192u: Fix sparse warning

Fix the following sparse warning:
rtl8192u/ieee80211/ieee80211_rx.c:1489:45: warning: incorrect type in assignment (different base types)
rtl8192u/ieee80211/ieee80211_rx.c:1489:45:    expected restricted __le16 <noident>
rtl8192u/ieee80211/ieee80211_rx.c:1489:45:    got unsigned short [unsigned] [usertype] <noident>

Since ac_params->tx_op_limit is already an __le16, we shouldn't convert it into cpu type.

Signed-off-by: Marcos Paulo de Souza <marcos.souza.org@...il.com>
---

 Sorry, I don't have the hardware to test, so please review and tell me if I'm wrong in this one!

 drivers/staging/rtl8192u/ieee80211/ieee80211_rx.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/staging/rtl8192u/ieee80211/ieee80211_rx.c b/drivers/staging/rtl8192u/ieee80211/ieee80211_rx.c
index 5241c50..3a6a533 100644
--- a/drivers/staging/rtl8192u/ieee80211/ieee80211_rx.c
+++ b/drivers/staging/rtl8192u/ieee80211/ieee80211_rx.c
@@ -1486,7 +1486,7 @@ static int ieee80211_qos_convert_ac_to_parameters(struct
 
 		qos_param->flag[aci] =
 		    (ac_params->aci_aifsn & 0x10) ? 0x01 : 0x00;
-		qos_param->tx_op_limit[aci] = le16_to_cpu(ac_params->tx_op_limit);
+		qos_param->tx_op_limit[aci] = ac_params->tx_op_limit;
 	}
 	return 0;
 }
-- 
2.9.3