linux-kernel - Re: [PATCH] scsi/mac_esp: Replace bogus memory barrier with spinlock

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <yq1lgqph21t.fsf@oracle.com>
Date:   Mon, 24 Apr 2017 18:29:50 -0400
From:   "Martin K. Petersen" <martin.petersen@...cle.com>
To:     Finn Thain <fthain@...egraphics.com.au>,
        Ondrej Zary <linux@...nbow-software.org>,
        Michael Schmitz <schmitzmic@...il.com>
Cc:     "James E.J. Bottomley" <jejb@...ux.vnet.ibm.com>,
        "Martin K. Petersen" <martin.petersen@...cle.com>,
        <linux-scsi@...r.kernel.org>, <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] scsi/mac_esp: Replace bogus memory barrier with spinlock


Finn,

> Commit da244654c66e ("[SCSI] mac_esp: fix for quadras with two esp chips")
> added mac_scsi_esp_intr() to handle the IRQ lines from a pair of on-board
> ESP chips (a normal shared IRQ did not work).
>
> Proper mutual exclusion was missing from that patch. This patch fixes
> race conditions between comparison and assignment of esp_chips[]
> pointers.

Ondrej/Michael: Mind reviewing this change?

-- 
Martin K. Petersen	Oracle Linux Engineering